Avoid casting away a const

petere · petere · commit 893d6f8a1f9b · 2019-03-16T10:13:03.000+01:00
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
@@ -269,7 +269,7 @@ bool		recoveryTargetInclusive = true;
 int			recoveryTargetAction = RECOVERY_TARGET_ACTION_PAUSE;
 TransactionId recoveryTargetXid;
 TimestampTz recoveryTargetTime;
-char	   *recoveryTargetName;
+const char *recoveryTargetName;
 XLogRecPtr	recoveryTargetLSN;
 int			recovery_min_apply_delay = 0;
 TimestampTz recoveryDelayUntilTime;
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -11434,7 +11434,7 @@ assign_recovery_target_name(const char *newval, void *extra)
 	if (newval && strcmp(newval, "") != 0)
 	{
 		recoveryTarget = RECOVERY_TARGET_NAME;
-		recoveryTargetName = (char *) newval;
+		recoveryTargetName = newval;
 	}
 	else
 		recoveryTarget = RECOVERY_TARGET_UNSET;
diff --git a/src/include/access/xlog.h b/src/include/access/xlog.h
@@ -131,7 +131,7 @@ extern char *PrimarySlotName;
 /* indirectly set via GUC system */
 extern TransactionId recoveryTargetXid;
 extern TimestampTz recoveryTargetTime;
-extern char *recoveryTargetName;
+extern const char *recoveryTargetName;
 extern XLogRecPtr recoveryTargetLSN;
 extern RecoveryTargetType recoveryTarget;
 extern char *PromoteTriggerFile;

Original file line number	Diff line number	Diff line change
`@@ -11434,7 +11434,7 @@ assign_recovery_target_name(const char newval, void extra)`
`11434`	`11434`	`if (newval && strcmp(newval, "") != 0)`
`11435`	`11435`	`{`
`11436`	`11436`	`recoveryTarget = RECOVERY_TARGET_NAME;`
`11437`		`- recoveryTargetName = (char *) newval;`
	`11437`	`+ recoveryTargetName = newval;`
`11438`	`11438`	`}`
`11439`	`11439`	`else`
`11440`	`11440`	`recoveryTarget = RECOVERY_TARGET_UNSET;`