Skip to content

Commit 89f6443

Browse files
committed
In the meaning of bug-fix, the patch is not needed. Because you
have already modified "next_insert()" in 7.0-ecpglib. However in the meaning of speed-up, the patch will be needed. -- Regards, SAKAIDA Masaaki -- Osaka, Japan
1 parent e05f154 commit 89f6443

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

doc/TODO

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ ENHANCEMENTS
5555

5656
URGENT
5757

58-
* Add OUTER joins, left and right[outer](Thomas, Bruce)
58+
* -Add OUTER joins, left and right[outer](Tom, Thomas)
5959
* Allow long tuples by chaining or auto-storing outside db (TOAST)(Jan)
6060
* Fix memory leak for expressions[memory](Tom?)
6161

src/interfaces/ecpg/lib/execute.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ ECPGexecute(struct statement * stmt)
377377
char *tobeinserted = NULL;
378378
char *p;
379379
char buff[20];
380+
int hostvarl = 0;
380381

381382
/*
382383
* Some special treatment is needed for records since we want
@@ -701,7 +702,7 @@ ECPGexecute(struct statement * stmt)
701702
return false;
702703

703704
strcpy(newcopy, copiedquery);
704-
if ((p = next_insert(newcopy)) == NULL)
705+
if ((p = next_insert(newcopy + hostvarl)) == NULL)
705706
{
706707

707708
/*
@@ -714,6 +715,7 @@ ECPGexecute(struct statement * stmt)
714715
else
715716
{
716717
strcpy(p, tobeinserted);
718+
hostvarl = strlen(newcopy);
717719

718720
/*
719721
* The strange thing in the second argument is the rest of the
@@ -993,7 +995,7 @@ ECPGdo(int lineno, const char *connection_name, char *query,...)
993995
*
994996
* Copyright (c) 2000, Christof Petig <christof.petig@wtal.de>
995997
*
996-
* $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/execute.c,v 1.11 2000/09/26 11:41:43 meskes Exp $
998+
* $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/execute.c,v 1.12 2000/10/02 16:15:53 momjian Exp $
997999
*/
9981000

9991001
PGconn *ECPG_internal_get_connection(char *name);

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy