Fix elog(FATAL) before PostmasterMain() or just after fork().

nmisch · nmisch · commit 8b9cbf492275 · 2024-12-10T13:51:59.000-08:00
Since commit 97550c0, these failed with "PANIC: proc_exit() called in child process" due to uninitialized or stale MyProcPid. That was reachable if close() failed in ClosePostmasterPorts() or setlocale(category, "C") failed, both unlikely. Back-patch to v13 (all supported versions). Discussion: https://postgr.es/m/20241208034614.45.nmisch@google.com
diff --git a/src/backend/main/main.c b/src/backend/main/main.c
@@ -32,6 +32,7 @@
 
 #include "bootstrap/bootstrap.h"
 #include "common/username.h"
+#include "miscadmin.h"
 #include "postmaster/postmaster.h"
 #include "tcop/tcopprot.h"
 #include "utils/help_config.h"
@@ -109,6 +110,7 @@ main(int argc, char *argv[])
 	 * localization of messages may not work right away, and messages won't go
 	 * anywhere but stderr until GUC settings get loaded.
 	 */
+	MyProcPid = getpid();
 	MemoryContextInit();
 
 	/*
diff --git a/src/backend/postmaster/fork_process.c b/src/backend/postmaster/fork_process.c
@@ -19,6 +19,7 @@
 #include <unistd.h>
 
 #include "libpq/pqsignal.h"
+#include "miscadmin.h"
 #include "postmaster/fork_process.h"
 
 #ifndef WIN32
@@ -66,6 +67,7 @@ fork_process(void)
 	if (result == 0)
 	{
 		/* fork succeeded, in child */
+		MyProcPid = getpid();
 #ifdef LINUX_PROFILE
 		setitimer(ITIMER_PROF, &prof_itimer, NULL);
 #endif
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -1899,14 +1899,13 @@ ClosePostmasterPorts(bool am_syslogger)
 
 
 /*
- * InitProcessGlobals -- set MyProcPid, MyStartTime[stamp], random seeds
+ * InitProcessGlobals -- set MyStartTime[stamp], random seeds
  *
  * Called early in the postmaster and every backend.
  */
 void
 InitProcessGlobals(void)
 {
-	MyProcPid = getpid();
 	MyStartTimestamp = GetCurrentTimestamp();
 	MyStartTime = timestamptz_to_time_t(MyStartTimestamp);
 
diff --git a/src/port/pqsignal.c b/src/port/pqsignal.c
@@ -74,8 +74,7 @@ static volatile pqsigfunc pqsignal_handlers[PG_NSIG];
 /*
  * Except when called with SIG_IGN or SIG_DFL, pqsignal() sets up this function
  * as the handler for all signals.  This wrapper handler function checks that
- * it is called within a process that the server knows about (i.e., any process
- * that has called InitProcessGlobals(), such as a client backend), and not a
+ * it is called within a process that knew to maintain MyProcPid, and not a
  * child process forked by system(3), etc.  This check ensures that such child
  * processes do not modify shared memory, which is often detrimental.  If the
  * check succeeds, the function originally provided to pqsignal() is called.

Original file line number	Diff line number	Diff line change
`@@ -1899,14 +1899,13 @@ ClosePostmasterPorts(bool am_syslogger)`
`1899`	`1899`
`1900`	`1900`
`1901`	`1901`	`/*`
`1902`		`- * InitProcessGlobals -- set MyProcPid, MyStartTime[stamp], random seeds`
	`1902`	`+ * InitProcessGlobals -- set MyStartTime[stamp], random seeds`
`1903`	`1903`	`*`
`1904`	`1904`	`* Called early in the postmaster and every backend.`
`1905`	`1905`	`*/`
`1906`	`1906`	`void`
`1907`	`1907`	`InitProcessGlobals(void)`
`1908`	`1908`	`{`
`1909`		`- MyProcPid = getpid();`
`1910`	`1909`	`MyStartTimestamp = GetCurrentTimestamp();`
`1911`	`1910`	`MyStartTime = timestamptz_to_time_t(MyStartTimestamp);`
`1912`	`1911`