Skip to content

Commit 8c1cd72

Browse files
michaelpqmichaelpq
committed
Remove recovery test 011_crash_recovery.pl
This test has been added as of 857ee8e that has introduced the SQL function txid_status(), with the purpose of checking that a transaction ID still in-progress during a crash is correctly marked as aborted after recovery finishes. This test is unstable, and some configuration scenarios may that easier to reproduce (wal_level=minimal, wal_compression=on) because the WAL holding the information about the in-progress transaction ID may not have made it to disk yet, hence a post-crash recovery may cause the same XID to be reused, triggering a test failure. We have discussed a few approaches, like making this function force a WAL flush to make it reliable across crashes, but we don't want to pay a performance penalty in some scenarios, as well. The test could have been tweaked to enforce a checkpoint but that actually breaks the promise of the test to rely on a stable result of txid_status() after a crash. This issue has been reported a few times across the past years, with an original report from Kyotaro Horiguchi. The buildfarm machines tanager, hachi and gokiburi enable wal_compression, and fail on this test periodically. Discussion: https://postgr.es/m/3163112.1674762209@sss.pgh.pa.us Discussion: https://postgr.es/m/20210305.115011.558061052471425531.horikyota.ntt@gmail.com Backpatch-through: 11
1 parent 54e72b6 commit 8c1cd72

File tree

2 files changed

+0
-64
lines changed

2 files changed

+0
-64
lines changed

‎src/test/recovery/meson.build

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ tests += {
1717
't/008_fsm_truncation.pl',
1818
't/009_twophase.pl',
1919
't/010_logical_decoding_timelines.pl',
20-
't/011_crash_recovery.pl',
2120
't/012_subtransactions.pl',
2221
't/013_crash_restart.pl',
2322
't/014_unlogged_reinit.pl',

‎src/test/recovery/t/011_crash_recovery.pl

Lines changed: 0 additions & 63 deletions
This file was deleted.

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy