Improve two error messages

petere · petere · commit 8e599897ca20 · 2018-07-12T12:35:59.000+02:00
diff --git a/src/backend/parser/parse_utilcmd.c b/src/backend/parser/parse_utilcmd.c
@@ -2098,7 +2098,7 @@ transformIndexConstraint(Constraint *constraint, CreateStmtContext *cxt)
 					index_rel->rd_indoption[i] != 0)
 					ereport(ERROR,
 							(errcode(ERRCODE_WRONG_OBJECT_TYPE),
-							 errmsg("index \"%s\" does not have default sorting behavior", index_name),
+							 errmsg("index \"%s\" column number %d does not have default sorting behavior", index_name, i + 1),
 							 errdetail("Cannot create a primary key or unique constraint using such an index."),
 							 parser_errposition(cxt->pstate, constraint->location)));
 
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
@@ -382,8 +382,10 @@ check_new_cluster_is_empty(void)
 		{
 			/* pg_largeobject and its index should be skipped */
 			if (strcmp(rel_arr->rels[relnum].nspname, "pg_catalog") != 0)
-				pg_fatal("New cluster database \"%s\" is not empty\n",
-						 new_cluster.dbarr.dbs[dbnum].db_name);
+				pg_fatal("New cluster database \"%s\" is not empty: found relation \"%s.%s\"\n",
+						 new_cluster.dbarr.dbs[dbnum].db_name,
+						 rel_arr->rels[relnum].nspname,
+						 rel_arr->rels[relnum].relname);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -382,8 +382,10 @@ check_new_cluster_is_empty(void)`
`382`	`382`	`{`
`383`	`383`	`/* pg_largeobject and its index should be skipped */`
`384`	`384`	`if (strcmp(rel_arr->rels[relnum].nspname, "pg_catalog") != 0)`
`385`		`- pg_fatal("New cluster database \"%s\" is not empty\n",`
`386`		`- new_cluster.dbarr.dbs[dbnum].db_name);`
	`385`	`+ pg_fatal("New cluster database \"%s\" is not empty: found relation \"%s.%s\"\n",`
	`386`	`+ new_cluster.dbarr.dbs[dbnum].db_name,`
	`387`	`+ rel_arr->rels[relnum].nspname,`
	`388`	`+ rel_arr->rels[relnum].relname);`
`387`	`389`	`}`
`388`	`390`	`}`
`389`	`391`	`}`