Allow binary-coercible cases in ri_HashCompareOp; there are some such cases

tglsfdc · tglsfdc · commit 8e7927769976 · 2009-11-05T04:38:29.000Z
that are not handled by find_coercion_pathway, notably composite-&gt;RECORD.
Now that 8.4 supports composites as primary keys, it's worth dealing with
this case.
diff --git a/src/backend/utils/adt/ri_triggers.c b/src/backend/utils/adt/ri_triggers.c
@@ -15,7 +15,7 @@
  *
  * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/ri_triggers.c,v 1.114 2009/08/01 19:59:41 tgl Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/ri_triggers.c,v 1.115 2009/11/05 04:38:29 tgl Exp $
  *
  * ----------
  */
@@ -3963,10 +3963,12 @@ ri_HashCompareOp(Oid eq_opr, Oid typeid)
 			{
 				/*
 				 * The declared input type of the eq_opr might be a
-				 * polymorphic type such as ANYARRAY or ANYENUM.  If so,
-				 * assume the coercion is valid; otherwise complain.
+				 * polymorphic type such as ANYARRAY or ANYENUM, or other
+				 * special cases such as RECORD; find_coercion_pathway
+				 * currently doesn't subsume these special cases.
 				 */
-				if (!IsPolymorphicType(lefttype))
+				if (!IsPolymorphicType(lefttype) &&
+					!IsBinaryCoercible(typeid, lefttype))
 					elog(ERROR, "no conversion function from %s to %s",
 						 format_type_be(typeid),
 						 format_type_be(lefttype));

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`*`
`16`	`16`	`* Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group`
`17`	`17`	`*`
`18`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/ri_triggers.c,v 1.114 2009/08/01 19:59:41 tgl Exp $`
	`18`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/ri_triggers.c,v 1.115 2009/11/05 04:38:29 tgl Exp $`
`19`	`19`	`*`
`20`	`20`	`* ----------`
`21`	`21`	`*/`
`@@ -3963,10 +3963,12 @@ ri_HashCompareOp(Oid eq_opr, Oid typeid)`
`3963`	`3963`	`{`
`3964`	`3964`	`/*`
`3965`	`3965`	`* The declared input type of the eq_opr might be a`
`3966`		`- * polymorphic type such as ANYARRAY or ANYENUM. If so,`
`3967`		`- * assume the coercion is valid; otherwise complain.`
	`3966`	`+ * polymorphic type such as ANYARRAY or ANYENUM, or other`
	`3967`	`+ * special cases such as RECORD; find_coercion_pathway`
	`3968`	`+ * currently doesn't subsume these special cases.`
`3968`	`3969`	`*/`
`3969`		`- if (!IsPolymorphicType(lefttype))`
	`3970`	`+ if (!IsPolymorphicType(lefttype) &&`
	`3971`	`+ !IsBinaryCoercible(typeid, lefttype))`
`3970`	`3972`	`elog(ERROR, "no conversion function from %s to %s",`
`3971`	`3973`	`format_type_be(typeid),`
`3972`	`3974`	`format_type_be(lefttype));`