Message style fix

petere · petere · commit 8ec8fe0f3171 · 2021-02-24T07:00:49.000+01:00
Don't quote type name placeholders.
diff --git a/src/backend/partitioning/partbounds.c b/src/backend/partitioning/partbounds.c
@@ -4755,7 +4755,7 @@ satisfies_hash_partition(PG_FUNCTION_ARGS)
 				if (argtype != key->parttypid[j] && !IsBinaryCoercible(argtype, key->parttypid[j]))
 					ereport(ERROR,
 							(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-							 errmsg("column %d of the partition key has type \"%s\", but supplied value is of type \"%s\"",
+							 errmsg("column %d of the partition key has type %s, but supplied value is of type %s",
 									j + 1, format_type_be(key->parttypid[j]), format_type_be(argtype))));
 
 				fmgr_info_copy(&my_extra->partsupfunc[j],
diff --git a/src/test/regress/expected/hash_part.out b/src/test/regress/expected/hash_part.out
@@ -48,7 +48,7 @@ SELECT satisfies_hash_partition('mchash'::regclass, 3, 1, NULL::int);
 ERROR:  number of partitioning columns (2) does not match number of partition keys provided (1)
 -- wrong argument type
 SELECT satisfies_hash_partition('mchash'::regclass, 2, 1, NULL::int, NULL::int);
-ERROR:  column 2 of the partition key has type "text", but supplied value is of type "integer"
+ERROR:  column 2 of the partition key has type text, but supplied value is of type integer
 -- ok, should be false
 SELECT satisfies_hash_partition('mchash'::regclass, 4, 0, 0, ''::text);
  satisfies_hash_partition 
