Fix minor memory leak in pg_dump

michaelpq · michaelpq · commit 8f4ee44bcdbc · 2020-04-15T15:56:01.000+09:00
A query used to read default ACL information from the catalogs did not free a set of PQExpBuffer. Oversight in commit e2090d9, so backpatch down to 9.6. Author: Jie Zhang Reviewed-by: Sawada Masahiko Discussion: https://postgr.es/m/05bcbc5857f948efa0b451b85a48ae10@G08CNEXMBPEKD06.g08.fujitsu.local Backpatch-through: 9.6
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -9592,6 +9592,11 @@ getDefaultACLs(Archive *fout, int *numDefaultACLs)
 						  racl_subquery->data,
 						  initacl_subquery->data,
 						  initracl_subquery->data);
+
+		destroyPQExpBuffer(acl_subquery);
+		destroyPQExpBuffer(racl_subquery);
+		destroyPQExpBuffer(initacl_subquery);
+		destroyPQExpBuffer(initracl_subquery);
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -9592,6 +9592,11 @@ getDefaultACLs(Archive fout, int numDefaultACLs)`
`9592`	`9592`	`racl_subquery->data,`
`9593`	`9593`	`initacl_subquery->data,`
`9594`	`9594`	`initracl_subquery->data);`
	`9595`	`+`
	`9596`	`+ destroyPQExpBuffer(acl_subquery);`
	`9597`	`+ destroyPQExpBuffer(racl_subquery);`
	`9598`	`+ destroyPQExpBuffer(initacl_subquery);`
	`9599`	`+ destroyPQExpBuffer(initracl_subquery);`
`9595`	`9600`	`}`
`9596`	`9601`	`else`
`9597`	`9602`	`{`