Skip to content

Commit 8f87dcd

Browse files
committed
Update new pg_upgrade comment about pre-8.4 TOAST tables.
1 parent 9e5bed2 commit 8f87dcd

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

contrib/pg_upgrade/info.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,11 @@ gen_db_file_maps(DbInfo *old_db, DbInfo *new_db,
5454
pg_log(PG_FATAL, "Mismatch of relation id: database \"%s\", old relid %d, new relid %d\n",
5555
old_db->db_name, old_rel->reloid, new_rel->reloid);
5656

57-
/* toast names were not renamed to match their relfilenodes in pre-8.4 */
57+
/*
58+
* In pre-8.4, TOAST table names change during CLUSTER; in >= 8.4
59+
* TOAST relation names always use the heap tables oid, hence we
60+
* cannot check relation names when upgrading from pre-8.4.
61+
*/
5862
if (GET_MAJOR_VERSION(old_cluster.major_version) >= 804 &&
5963
(strcmp(old_rel->nspname, new_rel->nspname) != 0 ||
6064
strcmp(old_rel->relname, new_rel->relname) != 0))

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy