Include <limits.h> in fe-auth.c, to get CHAR_BIT reliably.

tglsfdc · tglsfdc · commit 8fab4b348013 · 2023-07-17T16:54:54.000-04:00
fe-auth.c references CHAR_BIT since commit 3a465cc, but it did not #include <limits.h>, which per POSIX is where that symbol is defined. This escaped notice so far because (a) on most platforms, <sys/param.h> pulls in <limits.h>, (b) even if yours doesn't, OpenSSL pulls it in, so compiling with --with-openssl masks the omission. Per bug #18026 from Marcel Hofstetter. Back-patch to v16. Discussion: https://postgr.es/m/18026-d5bb69f79cd16203@postgresql.org
diff --git a/src/interfaces/libpq/fe-auth.c b/src/interfaces/libpq/fe-auth.c
@@ -27,6 +27,7 @@
 #else
 #include <unistd.h>
 #include <fcntl.h>
+#include <limits.h>
 #include <sys/param.h>			/* for MAXHOSTNAMELEN on most */
 #include <sys/socket.h>
 #ifdef HAVE_SYS_UCRED_H
