Remove a couple of unnecessary if-tests.

tglsfdc · tglsfdc · commit 91da65f4ac28 · 2019-11-24T12:03:16.000-05:00
Commit abd9ca3 replaced a couple of while-loops in fmtfloat() with calls to dopr_outchmulti, but I (tgl) failed to notice that the new if-tests guarding those calls were really unnecessary, because they're inside a larger if-block checking the same thing. Ranier Vilela Discussion: https://postgr.es/m/MN2PR18MB2927850AB00CF39CC370D107E34B0@MN2PR18MB2927.namprd18.prod.outlook.com
diff --git a/src/port/snprintf.c b/src/port/snprintf.c
@@ -1227,16 +1227,14 @@ fmtfloat(double value, char type, int forcesign, int leftjust,
 		{
 			/* pad before exponent */
 			dostr(convert, epos - convert, target);
-			if (zeropadlen > 0)
-				dopr_outchmulti('0', zeropadlen, target);
+			dopr_outchmulti('0', zeropadlen, target);
 			dostr(epos, vallen - (epos - convert), target);
 		}
 		else
 		{
 			/* no exponent, pad after the digits */
 			dostr(convert, vallen, target);
-			if (zeropadlen > 0)
-				dopr_outchmulti('0', zeropadlen, target);
+			dopr_outchmulti('0', zeropadlen, target);
 		}
 	}
 	else

Original file line number	Diff line number	Diff line change
`@@ -1227,16 +1227,14 @@ fmtfloat(double value, char type, int forcesign, int leftjust,`
`1227`	`1227`	`{`
`1228`	`1228`	`/* pad before exponent */`
`1229`	`1229`	`dostr(convert, epos - convert, target);`
`1230`		`- if (zeropadlen > 0)`
`1231`		`- dopr_outchmulti('0', zeropadlen, target);`
	`1230`	`+ dopr_outchmulti('0', zeropadlen, target);`
`1232`	`1231`	`dostr(epos, vallen - (epos - convert), target);`
`1233`	`1232`	`}`
`1234`	`1233`	`else`
`1235`	`1234`	`{`
`1236`	`1235`	`/* no exponent, pad after the digits */`
`1237`	`1236`	`dostr(convert, vallen, target);`
`1238`		`- if (zeropadlen > 0)`
`1239`		`- dopr_outchmulti('0', zeropadlen, target);`
	`1237`	`+ dopr_outchmulti('0', zeropadlen, target);`
`1240`	`1238`	`}`
`1241`	`1239`	`}`
`1242`	`1240`	`else`