Do not use an empty hostname.

Michael Meskes · Michael Meskes · commit 9484982740e8 · 2014-01-01T12:44:15.000+01:00
When trying to connect to a given database libecpg should not try using an
empty hostname if no hostname was given.
diff --git a/src/interfaces/ecpg/ecpglib/connect.c b/src/interfaces/ecpg/ecpglib/connect.c
@@ -324,7 +324,7 @@ ECPGconnect(int lineno, int c, const char *name, const char *user, const char *p
 
 	if (dbname != NULL)
 	{
-		/* get the detail information out of dbname */
+		/* get the detail information from dbname */
 		if (strncmp(dbname, "tcp:", 4) == 0 || strncmp(dbname, "unix:", 5) == 0)
 		{
 			int			offset = 0;
@@ -343,7 +343,7 @@ ECPGconnect(int lineno, int c, const char *name, const char *user, const char *p
 				/*------
 				 * new style:
 				 *	<tcp|unix>:postgresql://server[:port|:/unixsocket/path:]
-				 *	[/db name][?options]
+				 *	[/db-name][?options]
 				 *------
 				 */
 				offset += strlen("postgresql://");
@@ -418,8 +418,10 @@ ECPGconnect(int lineno, int c, const char *name, const char *user, const char *p
 					}
 				}
 				else
-					host = ecpg_strdup(dbname + offset, lineno);
-
+				{
+					if (*(dbname + offset) != '\0')
+						host = ecpg_strdup(dbname + offset, lineno);
+				}
 			}
 		}
 		else

Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ ECPGconnect(int lineno, int c, const char name, const char user, const char *p`
`324`	`324`
`325`	`325`	`if (dbname != NULL)`
`326`	`326`	`{`
`327`		`- /* get the detail information out of dbname */`
	`327`	`+ /* get the detail information from dbname */`
`328`	`328`	`if (strncmp(dbname, "tcp:", 4) == 0 \|\| strncmp(dbname, "unix:", 5) == 0)`
`329`	`329`	`{`
`330`	`330`	`int offset = 0;`
`@@ -343,7 +343,7 @@ ECPGconnect(int lineno, int c, const char name, const char user, const char *p`
`343`	`343`	`/*------`
`344`	`344`	`* new style:`
`345`	`345`	`* <tcp\|unix>:postgresql://server[:port\|:/unixsocket/path:]`
`346`		`- * [/db name][?options]`
	`346`	`+ * [/db-name][?options]`
`347`	`347`	`*------`
`348`	`348`	`*/`
`349`	`349`	`offset += strlen("postgresql://");`
`@@ -418,8 +418,10 @@ ECPGconnect(int lineno, int c, const char name, const char user, const char *p`
`418`	`418`	`}`
`419`	`419`	`}`
`420`	`420`	`else`
`421`		`- host = ecpg_strdup(dbname + offset, lineno);`
`422`		`-`
	`421`	`+ {`
	`422`	`+ if (*(dbname + offset) != '\0')`
	`423`	`+ host = ecpg_strdup(dbname + offset, lineno);`
	`424`	`+ }`
`423`	`425`	`}`
`424`	`426`	`}`
`425`	`427`	`else`