Initialize variables to placate compiler.

nathan-bossart · nathan-bossart · commit 949300402bde · 2024-03-17T20:16:15.000-05:00
Since commit 012460e, some compilers have been warning that a couple of variables may be used uninitialized. There doesn't appear to be any actual risk, so let's just initialize these variables to 0 to silence the compiler warnings. Discussion: https://postgr.es/m/20240317192927.GA3978212%40nathanxps13
diff --git a/src/backend/commands/statscmds.c b/src/backend/commands/statscmds.c
@@ -606,7 +606,7 @@ AlterStatistics(AlterStatsStmt *stmt)
 	bool		repl_null[Natts_pg_statistic_ext];
 	bool		repl_repl[Natts_pg_statistic_ext];
 	ObjectAddress address;
-	int			newtarget;
+	int			newtarget = 0;
 	bool		newtarget_default;
 
 	/* -1 was used in previous versions for the default setting */
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8711,7 +8711,7 @@ ATExecDropExpression(Relation rel, const char *colName, bool missing_ok, LOCKMOD
 static ObjectAddress
 ATExecSetStatistics(Relation rel, const char *colName, int16 colNum, Node *newValue, LOCKMODE lockmode)
 {
-	int			newtarget;
+	int			newtarget = 0;
 	bool		newtarget_default;
 	Relation	attrelation;
 	HeapTuple	tuple,

Original file line number	Diff line number	Diff line change
`@@ -8711,7 +8711,7 @@ ATExecDropExpression(Relation rel, const char *colName, bool missing_ok, LOCKMOD`
`8711`	`8711`	`static ObjectAddress`
`8712`	`8712`	`ATExecSetStatistics(Relation rel, const char colName, int16 colNum, Node newValue, LOCKMODE lockmode)`
`8713`	`8713`	`{`
`8714`		`- int newtarget;`
	`8714`	`+ int newtarget = 0;`
`8715`	`8715`	`bool newtarget_default;`
`8716`	`8716`	`Relation attrelation;`
`8717`	`8717`	`HeapTuple tuple,`