Fix bug in the new B-tree incomplete-split code.

hlinnaka · hlinnaka · commit 954523cdfe22 · 2014-04-01T19:19:47.000+03:00
Inserting a downlink to an internal page clears the incomplete-split flag
of the child's left sibling, so the left sibling's LSN also needs to be
updated.
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
@@ -910,6 +910,10 @@ _bt_insertonpg(Relation rel,
 			{
 				PageSetLSN(metapg, recptr);
 			}
+			if (BufferIsValid(cbuf))
+			{
+				PageSetLSN(BufferGetPage(cbuf), recptr);
+			}
 
 			PageSetLSN(page, recptr);
 		}
@@ -1402,6 +1406,10 @@ _bt_split(Relation rel, Buffer buf, Buffer cbuf, OffsetNumber firstright,
 		{
 			PageSetLSN(spage, recptr);
 		}
+		if (!isleaf)
+		{
+			PageSetLSN(BufferGetPage(cbuf), recptr);
+		}
 	}
 
 	END_CRIT_SECTION();

Original file line number	Diff line number	Diff line change
`@@ -910,6 +910,10 @@ _bt_insertonpg(Relation rel,`
`910`	`910`	`{`
`911`	`911`	`PageSetLSN(metapg, recptr);`
`912`	`912`	`}`
	`913`	`+ if (BufferIsValid(cbuf))`
	`914`	`+ {`
	`915`	`+ PageSetLSN(BufferGetPage(cbuf), recptr);`
	`916`	`+ }`
`913`	`917`
`914`	`918`	`PageSetLSN(page, recptr);`
`915`	`919`	`}`
`@@ -1402,6 +1406,10 @@ _bt_split(Relation rel, Buffer buf, Buffer cbuf, OffsetNumber firstright,`
`1402`	`1406`	`{`
`1403`	`1407`	`PageSetLSN(spage, recptr);`
`1404`	`1408`	`}`
	`1409`	`+ if (!isleaf)`
	`1410`	`+ {`
	`1411`	`+ PageSetLSN(BufferGetPage(cbuf), recptr);`
	`1412`	`+ }`
`1405`	`1413`	`}`
`1406`	`1414`
`1407`	`1415`	`END_CRIT_SECTION();`