Remove unnecessary check for jbvBinary in convertJsonbValue.

adunstan · adunstan · commit 960661980beb · 2014-06-18T19:28:20.000-04:00
The check was confusing and is a condition that should never in fact
happen.

Per gripe from Dmitry Dolgov.
diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c
@@ -1314,7 +1314,14 @@ convertJsonbValue(StringInfo buffer, JEntry *header, JsonbValue *val, int level)
 	if (!val)
 		return;
 
-	if (IsAJsonbScalar(val) || val->type == jbvBinary)
+	/*
+	 * A JsonbValue passed as val should never have a type of jbvBinary,
+	 * and neither should any of its sub-components. Those values will be
+	 * produced by convertJsonbArray and convertJsonbObject, the results of
+	 * which will not be passed back to this function as an argument.
+	 */
+
+	if (IsAJsonbScalar(val))
 		convertJsonbScalar(buffer, header, val);
 	else if (val->type == jbvArray)
 		convertJsonbArray(buffer, header, val, level);
