Skip to content

Commit 96b5eac

Browse files
committed
Correct some typos in the new JIT code.
Author: Thomas Munro
1 parent 32af96b commit 96b5eac

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/backend/jit/llvm/llvmjit.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ llvm_get_function(LLVMJitContext *context, const char *funcname)
247247

248248
/*
249249
* If there is a pending / not emitted module, compile and emit now.
250-
* Otherwise we migh not find the [correct] function.
250+
* Otherwise we might not find the [correct] function.
251251
*/
252252
if (!context->compiled)
253253
{
@@ -266,7 +266,7 @@ llvm_get_function(LLVMJitContext *context, const char *funcname)
266266

267267
addr = 0;
268268
if (LLVMOrcGetSymbolAddressIn(handle->stack, &addr, handle->orc_handle, funcname))
269-
elog(ERROR, "failed to lookup symbol \"%s\"", funcname);
269+
elog(ERROR, "failed to look up symbol \"%s\"", funcname);
270270
if (addr)
271271
return (void *) (uintptr_t) addr;
272272
}
@@ -280,11 +280,11 @@ llvm_get_function(LLVMJitContext *context, const char *funcname)
280280
return (void *) (uintptr_t) addr;
281281
#else
282282
if (LLVMOrcGetSymbolAddress(llvm_opt0_orc, &addr, funcname))
283-
elog(ERROR, "failed to lookup symbol \"%s\"", funcname);
283+
elog(ERROR, "failed to look up symbol \"%s\"", funcname);
284284
if (addr)
285285
return (void *) (uintptr_t) addr;
286286
if (LLVMOrcGetSymbolAddress(llvm_opt3_orc, &addr, funcname))
287-
elog(ERROR, "failed to lookup symbol \"%s\"", funcname);
287+
elog(ERROR, "failed to look up symbol \"%s\"", funcname);
288288
if (addr)
289289
return (void *) (uintptr_t) addr;
290290
#endif /* LLVM_VERSION_MAJOR */
@@ -540,7 +540,7 @@ llvm_compile_module(LLVMJitContext *context)
540540
if (LLVMOrcAddEagerlyCompiledIR(compile_orc, &orc_handle, smod,
541541
llvm_resolve_symbol, NULL))
542542
{
543-
elog(ERROR, "failed to jit module");
543+
elog(ERROR, "failed to JIT module");
544544
}
545545
LLVMOrcDisposeSharedModuleRef(smod);
546546
}
@@ -847,7 +847,7 @@ llvm_resolve_symbol(const char *symname, void *ctx)
847847
char *modname;
848848

849849
/*
850-
* OSX prefixes all object level symbols with an underscore. But neither
850+
* macOS prefixes all object level symbols with an underscore. But neither
851851
* dlsym() nor PG's inliner expect that. So undo.
852852
*/
853853
#if defined(__darwin__)

src/backend/jit/llvm/llvmjit_error.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* LLVM error related handling that requires interfacing with C++
55
*
66
* Unfortunately neither (re)setting the C++ new handler, nor the LLVM OOM
7-
* handler are exposed to C. Therefore this file wraps the necesary code.
7+
* handler are exposed to C. Therefore this file wraps the necessary code.
88
*
99
* Copyright (c) 2016-2018, PostgreSQL Global Development Group
1010
*
@@ -39,12 +39,12 @@ static void fatal_llvm_error_handler(void *user_data, const std::string& reason,
3939
*
4040
* This is necessary for LLVM as LLVM's error handling for such cases
4141
* (exit()ing, throwing std::bad_alloc() if compiled with exceptions, abort())
42-
* isn't compatible with postgres error handling. Thus in section where LLVM
42+
* isn't compatible with postgres error handling. Thus in sections where LLVM
4343
* code, not LLVM generated functions!, is executing, standard new, LLVM OOM
4444
* and LLVM fatal errors (some OOM errors masquerade as those) are redirected
4545
* to our own error handlers.
4646
*
47-
* These error handlers FATAL, because there's no reliable way from within
47+
* These error handlers use FATAL, because there's no reliable way from within
4848
* LLVM to throw an error that's guaranteed not to corrupt LLVM's state.
4949
*
5050
* To avoid disturbing extensions using C++ and/or LLVM, these handlers are

src/backend/jit/llvm/llvmjit_expr.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1984,7 +1984,7 @@ llvm_compile_expr(ExprState *state)
19841984
isnull;
19851985

19861986
/*
1987-
* At this point aggref->aggno is not yet set (it's setup
1987+
* At this point aggref->aggno is not yet set (it's set up
19881988
* in ExecInitAgg() after initializing the expression). So
19891989
* load it from memory each time round.
19901990
*/
@@ -2020,7 +2020,7 @@ llvm_compile_expr(ExprState *state)
20202020

20212021
/*
20222022
* At this point aggref->wfuncno is not yet set (it's
2023-
* setup in ExecInitWindowAgg() after initializing the
2023+
* set up in ExecInitWindowAgg() after initializing the
20242024
* expression). So load it from memory each time round.
20252025
*/
20262026
v_wfuncnop = l_ptr_const(&wfunc->wfuncno,

src/backend/jit/llvm/llvmjit_types.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* low chance of definitions getting out of sync, this file lists types and
99
* functions that directly need to be accessed from LLVM.
1010
*
11-
* When LlVM is first used in a backend, a bitcode version of this file, will
11+
* When LLVM is first used in a backend, a bitcode version of this file will
1212
* be loaded. The needed types and signatures will be stored into Struct*,
1313
* Type*, Func* variables.
1414
*

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy