Skip to content

Commit 979a36c

Browse files
committed
Adjust regression test cases added by commit ab72716.
I suppose it is a copy-and-paste error that this test doesn't actually test the "Parallel Append with both partial and non-partial subplans" case (EXPLAIN alone surely doesn't qualify as a test of executor behavior). Fix that. Also, add cosmetic aliases to make it possible to tell apart these otherwise-identical test cases in log_statement output.
1 parent 51cff91 commit 979a36c

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

src/test/regress/expected/select_parallel.out

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ explain (costs off)
2929
-> Parallel Seq Scan on f_star
3030
(11 rows)
3131

32-
select round(avg(aa)), sum(aa) from a_star;
32+
select round(avg(aa)), sum(aa) from a_star a1;
3333
round | sum
3434
-------+-----
3535
14 | 355
@@ -55,6 +55,12 @@ explain (costs off)
5555
-> Parallel Seq Scan on f_star
5656
(11 rows)
5757

58+
select round(avg(aa)), sum(aa) from a_star a2;
59+
round | sum
60+
-------+-----
61+
14 | 355
62+
(1 row)
63+
5864
-- Parallel Append with only non-partial subplans
5965
alter table a_star set (parallel_workers = 0);
6066
alter table b_star set (parallel_workers = 0);
@@ -77,7 +83,7 @@ explain (costs off)
7783
-> Seq Scan on a_star
7884
(11 rows)
7985

80-
select round(avg(aa)), sum(aa) from a_star;
86+
select round(avg(aa)), sum(aa) from a_star a3;
8187
round | sum
8288
-------+-----
8389
14 | 355
@@ -108,7 +114,7 @@ explain (costs off)
108114
-> Parallel Seq Scan on f_star
109115
(11 rows)
110116

111-
select round(avg(aa)), sum(aa) from a_star;
117+
select round(avg(aa)), sum(aa) from a_star a4;
112118
round | sum
113119
-------+-----
114120
14 | 355

src/test/regress/sql/select_parallel.sql

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,14 @@ set max_parallel_workers_per_gather=4;
1818
-- Parallel Append with partial-subplans
1919
explain (costs off)
2020
select round(avg(aa)), sum(aa) from a_star;
21-
select round(avg(aa)), sum(aa) from a_star;
21+
select round(avg(aa)), sum(aa) from a_star a1;
2222

2323
-- Parallel Append with both partial and non-partial subplans
2424
alter table c_star set (parallel_workers = 0);
2525
alter table d_star set (parallel_workers = 0);
2626
explain (costs off)
2727
select round(avg(aa)), sum(aa) from a_star;
28+
select round(avg(aa)), sum(aa) from a_star a2;
2829

2930
-- Parallel Append with only non-partial subplans
3031
alter table a_star set (parallel_workers = 0);
@@ -33,7 +34,7 @@ alter table e_star set (parallel_workers = 0);
3334
alter table f_star set (parallel_workers = 0);
3435
explain (costs off)
3536
select round(avg(aa)), sum(aa) from a_star;
36-
select round(avg(aa)), sum(aa) from a_star;
37+
select round(avg(aa)), sum(aa) from a_star a3;
3738

3839
-- Disable Parallel Append
3940
alter table a_star reset (parallel_workers);
@@ -45,7 +46,7 @@ alter table f_star reset (parallel_workers);
4546
set enable_parallel_append to off;
4647
explain (costs off)
4748
select round(avg(aa)), sum(aa) from a_star;
48-
select round(avg(aa)), sum(aa) from a_star;
49+
select round(avg(aa)), sum(aa) from a_star a4;
4950
reset enable_parallel_append;
5051

5152
-- test with leader participation disabled

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy