Suppress compiler warning in pub_collist_to_bitmapset().

tglsfdc · tglsfdc · commit 979cd655c13c · 2022-03-26T11:53:37.000-04:00
A fair percentage of the buildfarm doesn't recognize that oldcxt won't be used uninitialized; silence those warnings by initializing it. While here, upgrade the function's thoroughly inadequate header comment. Oversight in 923def9, per buildfarm.
diff --git a/src/backend/catalog/pg_publication.c b/src/backend/catalog/pg_publication.c
@@ -592,7 +592,11 @@ publication_translate_columns(Relation targetrel, List *columns,
 }
 
 /*
- * Transform the column list (represented by an array) to a bitmapset.
+ * Transform a column list (represented by an array Datum) to a bitmapset.
+ *
+ * If columns isn't NULL, add the column numbers to that set.
+ *
+ * If mcxt isn't NULL, build the bitmapset in that context.
  */
 Bitmapset *
 pub_collist_to_bitmapset(Bitmapset *columns, Datum pubcols, MemoryContext mcxt)
@@ -601,7 +605,7 @@ pub_collist_to_bitmapset(Bitmapset *columns, Datum pubcols, MemoryContext mcxt)
 	ArrayType  *arr;
 	int			nelems;
 	int16	   *elems;
-	MemoryContext	oldcxt;
+	MemoryContext	oldcxt = NULL;
 
 	/*
 	 * If an existing bitmap was provided, use it. Otherwise just use NULL
