Declare mkdtemp() only if we're providing it.

tglsfdc · tglsfdc · commit 98170fa46507 · 2014-10-17T22:55:36.000-04:00
Follow our usual style of providing an "extern" for a standard library function only when we're also providing the implementation. This avoids issues when the system headers declare the function slightly differently than we do, as noted by Caleb Welton. We might have to go to the extent of probing to see if the system headers declare the function, but let's not do that until it's demonstrated to be necessary. Oversight in commit 9e6b1bf. Back-patch to all supported branches, as that was.
diff --git a/src/include/port.h b/src/include/port.h
@@ -403,6 +403,10 @@ extern int	getopt(int nargc, char *const * nargv, const char *ostr);
 extern int	isinf(double x);
 #endif
 
+#ifndef HAVE_MKDTEMP
+extern char *mkdtemp(char *path);
+#endif
+
 #ifndef HAVE_RINT
 extern double rint(double x);
 #endif
@@ -464,7 +468,4 @@ extern void qsort_arg(void *base, size_t nel, size_t elsize,
 /* port/chklocale.c */
 extern int	pg_get_encoding_from_locale(const char *ctype);
 
-/* port/mkdtemp.c */
-extern char *mkdtemp(char *path);
-
 #endif   /* PG_PORT_H */
