Adjust comments that called MultiXactIds "XMIDs".

petergeoghegan · petergeoghegan · commit 9887dd38f966 · 2022-08-29T19:42:30.000-07:00
Oversights in commits 0b018fa and f3c15cb.
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -7218,7 +7218,7 @@ heap_tuple_needs_eventual_freeze(HeapTupleHeader tuple)
  * heap_tuple_would_freeze
  *
  * Return value indicates if heap_prepare_freeze_tuple sibling function would
- * freeze any of the XID/XMID fields from the tuple, given the same cutoffs.
+ * freeze any of the XID/MXID fields from the tuple, given the same cutoffs.
  * We must also deal with dead tuples here, since (xmin, xmax, xvac) fields
  * could be processed by pruning away the whole tuple instead of freezing.
  *
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
@@ -951,7 +951,7 @@ get_all_vacuum_rels(int options)
  * oldestXmin and oldestMxact are the most recent values that can ever be
  * passed to vac_update_relstats() as frozenxid and minmulti arguments by our
  * vacuumlazy.c caller later on.  These values should be passed when it turns
- * out that VACUUM will leave no unfrozen XIDs/XMIDs behind in the table.
+ * out that VACUUM will leave no unfrozen XIDs/MXIDs behind in the table.
  */
 bool
 vacuum_set_xid_limits(Relation rel,
diff --git a/src/test/isolation/specs/vacuum-no-cleanup-lock.spec b/src/test/isolation/specs/vacuum-no-cleanup-lock.spec
@@ -127,7 +127,7 @@ permutation
 #
 # This provides test coverage for code paths that are only hit when we need to
 # freeze, but inability to acquire a cleanup lock on a heap page makes
-# freezing some XIDs/XMIDs < FreezeLimit/MultiXactCutoff impossible (without
+# freezing some XIDs/MXIDs < FreezeLimit/MultiXactCutoff impossible (without
 # waiting for a cleanup lock, which non-aggressive VACUUM is unwilling to do).
 permutation
     dml_begin

Original file line number	Diff line number	Diff line change
`@@ -7218,7 +7218,7 @@ heap_tuple_needs_eventual_freeze(HeapTupleHeader tuple)`
`7218`	`7218`	`* heap_tuple_would_freeze`
`7219`	`7219`	`*`
`7220`	`7220`	`* Return value indicates if heap_prepare_freeze_tuple sibling function would`
`7221`		`- * freeze any of the XID/XMID fields from the tuple, given the same cutoffs.`
	`7221`	`+ * freeze any of the XID/MXID fields from the tuple, given the same cutoffs.`
`7222`	`7222`	`* We must also deal with dead tuples here, since (xmin, xmax, xvac) fields`
`7223`	`7223`	`* could be processed by pruning away the whole tuple instead of freezing.`
`7224`	`7224`	`*`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ permutation`
`127`	`127`	`#`
`128`	`128`	`# This provides test coverage for code paths that are only hit when we need to`
`129`	`129`	`# freeze, but inability to acquire a cleanup lock on a heap page makes`
`130`		`-# freezing some XIDs/XMIDs < FreezeLimit/MultiXactCutoff impossible (without`
	`130`	`+# freezing some XIDs/MXIDs < FreezeLimit/MultiXactCutoff impossible (without`
`131`	`131`	`# waiting for a cleanup lock, which non-aggressive VACUUM is unwilling to do).`
`132`	`132`	`permutation`
`133`	`133`	`dml_begin`