Fix pg_upgrade's pg_scandir_internal() to properly handle a NULL

bmomjian · bmomjian · commit 988f907d2437 · 2011-11-17T13:24:54.000-05:00
pattern, which is used on PG 9.1 and HEAD (but not pre-9.1).  Fixes
crash on Windows.

Backpatched to 9.1.

Reported by Mark Dilger
diff --git a/contrib/pg_upgrade/file.c b/contrib/pg_upgrade/file.c
@@ -296,7 +296,7 @@ pg_scandir_internal(const char *dirname,
 	while ((direntry = readdir(dirdesc)) != NULL)
 	{
 		/* Invoke the selector function to see if the direntry matches */
-		if ((*selector) (direntry))
+		if (selector && (*selector) (direntry))
 		{
 			count++;
 

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ pg_scandir_internal(const char *dirname,`
`296`	`296`	`while ((direntry = readdir(dirdesc)) != NULL)`
`297`	`297`	`{`
`298`	`298`	`/* Invoke the selector function to see if the direntry matches */`
`299`		`- if ((*selector) (direntry))`
	`299`	`+ if (selector && (*selector) (direntry))`
`300`	`300`	`{`
`301`	`301`	`count++;`
`302`	`302`