pg_locale.c: change ereport() to elog().

jeff-davis · jeff-davis · commit 9a242899158c · 2023-03-24T08:47:42.000-07:00
Discussion: https://postgr.es/m/73553013-3926-0f34-0fb8-f37909fe4902@enterprisedb.com Reported-by: Peter Eisentraut
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
@@ -2507,16 +2507,15 @@ pg_ucol_open(const char *loc_str)
 
 	/*
 	 * Must never open default collator, because it depends on the environment
-	 * and may change at any time.
+	 * and may change at any time. Should not happen, but check here to catch
+	 * bugs that might be hard to catch otherwise.
 	 *
 	 * NB: the default collator is not the same as the collator for the root
 	 * locale. The root locale may be specified as the empty string, "und", or
 	 * "root". The default collator is opened by passing NULL to ucol_open().
 	 */
 	if (loc_str == NULL)
-		ereport(ERROR,
-				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-				 errmsg("opening default collator is not supported")));
+		elog(ERROR, "opening default collator is not supported");
 
 	/*
 	 * In ICU versions 54 and earlier, "und" is not a recognized spelling of
