Avoid unnecessary strcasecmp -- replace by strcmp. Fixes reported bug

petere · petere · commit 9e774ca45e00 · 2001-09-19T15:19:12.000Z
that made setting serializable isolation level impossible in Turkish
locale.
diff --git a/src/backend/commands/variable.c b/src/backend/commands/variable.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/variable.c,v 1.52 2001/09/06 04:57:28 ishii Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/variable.c,v 1.53 2001/09/19 15:19:12 petere Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -462,12 +462,12 @@ parse_XactIsoLevel(char *value)
 	}
 
 
-	if (strcasecmp(value, "SERIALIZABLE") == 0)
+	if (strcmp(value, "serializable") == 0)
 		XactIsoLevel = XACT_SERIALIZABLE;
-	else if (strcasecmp(value, "READ COMMITTED") == 0)
+	else if (strcmp(value, "read committed") == 0)
 		XactIsoLevel = XACT_READ_COMMITTED;
 	else
-		elog(ERROR, "Bad TRANSACTION ISOLATION LEVEL (%s)", value);
+		elog(ERROR, "invalid transaction isolation level: %s", value);
 
 	return TRUE;
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $Header: /cvsroot/pgsql/src/backend/commands/variable.c,v 1.52 2001/09/06 04:57:28 ishii Exp $`
	`12`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/variable.c,v 1.53 2001/09/19 15:19:12 petere Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -462,12 +462,12 @@ parse_XactIsoLevel(char *value)`
`462`	`462`	`}`
`463`	`463`
`464`	`464`
`465`		`- if (strcasecmp(value, "SERIALIZABLE") == 0)`
	`465`	`+ if (strcmp(value, "serializable") == 0)`
`466`	`466`	`XactIsoLevel = XACT_SERIALIZABLE;`
`467`		`- else if (strcasecmp(value, "READ COMMITTED") == 0)`
	`467`	`+ else if (strcmp(value, "read committed") == 0)`
`468`	`468`	`XactIsoLevel = XACT_READ_COMMITTED;`
`469`	`469`	`else`
`470`		`- elog(ERROR, "Bad TRANSACTION ISOLATION LEVEL (%s)", value);`
	`470`	`+ elog(ERROR, "invalid transaction isolation level: %s", value);`
`471`	`471`
`472`	`472`	`return TRUE;`
`473`	`473`	`}`