Remove obsolete _bt_insert_parent() comment.

petergeoghegan · petergeoghegan · commit 9ee7414ed043 · 2019-04-29T14:14:38.000-07:00
Remove a comment that refers to a coding practice that was fully removed by commit a8b8f4d, which introduced MarkBufferDirty(). It looks like the comment was even obsolete before then, since it concerns write-ordering dependencies with synchronous buffer writes.
diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
@@ -1786,7 +1786,6 @@ _bt_insert_parent(Relation rel,
 		 */
 		_bt_relbuf(rel, rbuf);
 
-		/* Check for error only after writing children */
 		if (pbuf == InvalidBuffer)
 			elog(ERROR, "failed to re-find parent key in index \"%s\" for split pages %u/%u",
 				 RelationGetRelationName(rel), bknum, rbknum);
