Fix unportable usage of isspace().

tglsfdc · tglsfdc · commit a149d8bd56ed · 2013-06-01T13:58:23.000-04:00
Must cast char argument to unsigned to avoid doing the wrong thing with high-bit-set characters. Oversight in commit 30b5ede.
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -1134,7 +1134,7 @@ escapeConnectionParameter(const char *src)
 
 	for (p = src; *p; p++)
 	{
-		if (isspace(*p))
+		if (isspace((unsigned char) *p))
 		{
 			need_quotes = true;
 			break;

Original file line number	Diff line number	Diff line change
`@@ -1134,7 +1134,7 @@ escapeConnectionParameter(const char *src)`
`1134`	`1134`
`1135`	`1135`	`for (p = src; *p; p++)`
`1136`	`1136`	`{`
`1137`		`- if (isspace(*p))`
	`1137`	`+ if (isspace((unsigned char) *p))`
`1138`	`1138`	`{`
`1139`	`1139`	`need_quotes = true;`
`1140`	`1140`	`break;`