Skip to content

Commit a1f7f80

Browse files
committed
Update outdated comments in nodeAgg.c.
Author: Zhang Mingli Reviewed-by: Richard Guo Discussion: https://postgr.es/m/198a8d1e-0792-4e7f-828e-902aa342f36e@Spark
1 parent c623e85 commit a1f7f80

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/backend/executor/nodeAgg.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,7 +1454,7 @@ find_cols_walker(Node *node, FindColsContext *context)
14541454
* To implement hashed aggregation, we need a hashtable that stores a
14551455
* representative tuple and an array of AggStatePerGroup structs for each
14561456
* distinct set of GROUP BY column values. We compute the hash key from the
1457-
* GROUP BY columns. The per-group data is allocated in lookup_hash_entry(),
1457+
* GROUP BY columns. The per-group data is allocated in initialize_hash_entry(),
14581458
* for each entry.
14591459
*
14601460
* We have a separate hashtable and associated perhash data structure for each
@@ -1551,7 +1551,7 @@ build_hash_table(AggState *aggstate, int setno, long nbuckets)
15511551
* at all. Only columns of the first two types need to be stored in the
15521552
* hashtable, and getting rid of the others can make the table entries
15531553
* significantly smaller. The hashtable only contains the relevant columns,
1554-
* and is packed/unpacked in lookup_hash_entry() / agg_retrieve_hash_table()
1554+
* and is packed/unpacked in lookup_hash_entries() / agg_retrieve_hash_table()
15551555
* into the format of the normal input descriptor.
15561556
*
15571557
* Additional columns, in addition to the columns grouped by, come from two
@@ -2102,8 +2102,6 @@ initialize_hash_entry(AggState *aggstate, TupleHashTable hashtable,
21022102
/*
21032103
* Look up hash entries for the current tuple in all hashed grouping sets.
21042104
*
2105-
* Be aware that lookup_hash_entry can reset the tmpcontext.
2106-
*
21072105
* Some entries may be left NULL if we are in "spill mode". The same tuple
21082106
* will belong to different groups for each grouping set, so may match a group
21092107
* already in memory for one set and match a group not in memory for another

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy