Fix Hot Standby feedback sending when streaming busily.

hlinnaka · hlinnaka · commit a472ae1e4e2b · 2014-01-16T23:15:41.000+02:00
Commit 6f60fdd accidentally removed a call to XLogWalRcvSendHSFeedback() after flushing received WAL to disk. The consequence is that when walsender is busy streaming WAL, it doesn't send HS feedback messages. One is sent if nothing is received from the master for 100ms, but if there's a steady stream of WAL, it never happens. Backpatch to 9.3. Andres Freund and Amit Kapila
diff --git a/src/backend/replication/walreceiver.c b/src/backend/replication/walreceiver.c
@@ -1007,7 +1007,10 @@ XLogWalRcvFlush(bool dying)
 
 		/* Also let the master know that we made some progress */
 		if (!dying)
+		{
 			XLogWalRcvSendReply(false, false);
+			XLogWalRcvSendHSFeedback(false);
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1007,7 +1007,10 @@ XLogWalRcvFlush(bool dying)`
`1007`	`1007`
`1008`	`1008`	`/* Also let the master know that we made some progress */`
`1009`	`1009`	`if (!dying)`
	`1010`	`+ {`
`1010`	`1011`	`XLogWalRcvSendReply(false, false);`
	`1012`	`+ XLogWalRcvSendHSFeedback(false);`
	`1013`	`+ }`
`1011`	`1014`	`}`
`1012`	`1015`	`}`
`1013`	`1016`