Remove somebody's ill-considered free() call, per report from Chander Ganesan.

tglsfdc · tglsfdc · commit a50606de91fe · 2006-10-12T05:14:49.000Z
No, I do not care whether Coverity considers this a memory leak.
It's entirely not worth the code space to do it correctly.
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
@@ -4,7 +4,7 @@
  *
  * Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.73 2006/10/04 00:30:04 momjian Exp $
+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.74 2006/10/12 05:14:49 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -858,7 +858,6 @@ do_status(void)
 				if (optlines != NULL)
 					for (; *optlines != NULL; optlines++)
 						fputs(*optlines, stdout);
-				free(optlines);
 				return;
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`*`
`5`	`5`	`* Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group`
`6`	`6`	`*`
`7`		`- * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.73 2006/10/04 00:30:04 momjian Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/bin/pg_ctl/pg_ctl.c,v 1.74 2006/10/12 05:14:49 tgl Exp $`
`8`	`8`	`*`
`9`	`9`	`*-------------------------------------------------------------------------`
`10`	`10`	`*/`
`@@ -858,7 +858,6 @@ do_status(void)`
`858`	`858`	`if (optlines != NULL)`
`859`	`859`	`for (; *optlines != NULL; optlines++)`
`860`	`860`	`fputs(*optlines, stdout);`
`861`		`- free(optlines);`
`862`	`861`	`return;`
`863`	`862`	`}`
`864`	`863`	`}`