Guard against null t->tm_zone in strftime.c.

tglsfdc · tglsfdc · commit a54d5875fe0b · 2017-05-07T12:33:12.000-04:00
The upstream IANA code does not guard against null TM_ZONE pointers in this
function, but in our code there is such a check in the other pre-existing
use of t-&gt;tm_zone.  We do have some places that set pg_tm.tm_zone to NULL.
I'm not entirely sure it's possible to reach strftime with such a value,
but I'm not sure it isn't either, so be safe.

Per Coverity complaint.
diff --git a/src/timezone/strftime.c b/src/timezone/strftime.c
@@ -458,7 +458,8 @@ _fmt(const char *format, const struct pg_tm * t, char *pt, const char *ptlim,
 						negative = diff < 0;
 						if (diff == 0)
 						{
-							negative = t->tm_zone[0] == '-';
+							if (t->tm_zone != NULL)
+								negative = t->tm_zone[0] == '-';
 						}
 						if (negative)
 						{

Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,8 @@ _fmt(const char format, const struct pg_tm t, char pt, const char ptlim,`
`458`	`458`	`negative = diff < 0;`
`459`	`459`	`if (diff == 0)`
`460`	`460`	`{`
`461`		`- negative = t->tm_zone[0] == '-';`
	`461`	`+ if (t->tm_zone != NULL)`
	`462`	`+ negative = t->tm_zone[0] == '-';`
`462`	`463`	`}`
`463`	`464`	`if (negative)`
`464`	`465`	`{`