Fix some compiler warnings on older compilers

petere · petere · commit a63c84e59acf · 2019-11-04T11:07:32.000+01:00
Some older compilers appear to not understand the recently introduced PG_FINALLY code structure that well in some circumstances and complain about possibly uninitialized variables. So to fix, initialize the variables explicitly in the cases complained about. Discussion: https://www.postgresql.org/message-id/flat/95a822c3-728b-af0e-d7e5-71890507ae0c%402ndquadrant.com
diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
@@ -3821,7 +3821,7 @@ SPI_sql_row_to_xmlelement(uint64 rownum, StringInfo result, char *tablename,
 static text *
 xml_xmlnodetoxmltype(xmlNodePtr cur, PgXmlErrorContext *xmlerrcxt)
 {
-	xmltype    *result;
+	xmltype    *result = NULL;
 
 	if (cur->type != XML_ATTRIBUTE_NODE && cur->type != XML_TEXT_NODE)
 	{
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
@@ -1840,7 +1840,7 @@ PG_FUNCTION_INFO_V1(plperl_call_handler);
 Datum
 plperl_call_handler(PG_FUNCTION_ARGS)
 {
-	Datum		retval;
+	Datum		retval = (Datum) 0;
 	plperl_call_data *volatile save_call_data = current_call_data;
 	plperl_interp_desc *volatile oldinterp = plperl_active_interp;
 	plperl_call_data this_call_data;
diff --git a/src/pl/plpython/plpy_exec.c b/src/pl/plpython/plpy_exec.c
@@ -1025,7 +1025,7 @@ plpython_trigger_error_callback(void *arg)
 static PyObject *
 PLy_procedure_call(PLyProcedure *proc, const char *kargs, PyObject *vargs)
 {
-	PyObject   *rv;
+	PyObject   *rv = NULL;
 	int volatile save_subxact_level = list_length(explicit_subtransactions);
 
 	PyDict_SetItemString(proc->globals, kargs, vargs);
diff --git a/src/pl/plpython/plpy_typeio.c b/src/pl/plpython/plpy_typeio.c
@@ -901,7 +901,7 @@ PLyObject_ToBytea(PLyObToDatum *arg, PyObject *plrv,
 				  bool *isnull, bool inarray)
 {
 	PyObject   *volatile plrv_so = NULL;
-	Datum		rv;
+	Datum		rv = (Datum) 0;
 
 	if (plrv == Py_None)
 	{
diff --git a/src/pl/tcl/pltcl.c b/src/pl/tcl/pltcl.c
@@ -718,7 +718,7 @@ pltclu_call_handler(PG_FUNCTION_ARGS)
 static Datum
 pltcl_handler(PG_FUNCTION_ARGS, bool pltrusted)
 {
-	Datum		retval;
+	Datum		retval = (Datum) 0;
 	pltcl_call_state current_call_state;
 	pltcl_call_state *save_call_state;
 

Original file line number	Diff line number	Diff line change
`@@ -3821,7 +3821,7 @@ SPI_sql_row_to_xmlelement(uint64 rownum, StringInfo result, char *tablename,`
`3821`	`3821`	`static text *`
`3822`	`3822`	`xml_xmlnodetoxmltype(xmlNodePtr cur, PgXmlErrorContext *xmlerrcxt)`
`3823`	`3823`	`{`
`3824`		`- xmltype *result;`
	`3824`	`+ xmltype *result = NULL;`
`3825`	`3825`
`3826`	`3826`	`if (cur->type != XML_ATTRIBUTE_NODE && cur->type != XML_TEXT_NODE)`
`3827`	`3827`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1840,7 +1840,7 @@ PG_FUNCTION_INFO_V1(plperl_call_handler);`
`1840`	`1840`	`Datum`
`1841`	`1841`	`plperl_call_handler(PG_FUNCTION_ARGS)`
`1842`	`1842`	`{`
`1843`		`- Datum retval;`
	`1843`	`+ Datum retval = (Datum) 0;`
`1844`	`1844`	`plperl_call_data *volatile save_call_data = current_call_data;`
`1845`	`1845`	`plperl_interp_desc *volatile oldinterp = plperl_active_interp;`
`1846`	`1846`	`plperl_call_data this_call_data;`
Original file line number	Diff line number	Diff line change
`@@ -1025,7 +1025,7 @@ plpython_trigger_error_callback(void *arg)`
`1025`	`1025`	`static PyObject *`
`1026`	`1026`	`PLy_procedure_call(PLyProcedure proc, const char kargs, PyObject *vargs)`
`1027`	`1027`	`{`
`1028`		`- PyObject *rv;`
	`1028`	`+ PyObject *rv = NULL;`
`1029`	`1029`	`int volatile save_subxact_level = list_length(explicit_subtransactions);`
`1030`	`1030`
`1031`	`1031`	`PyDict_SetItemString(proc->globals, kargs, vargs);`
Original file line number	Diff line number	Diff line change
`@@ -901,7 +901,7 @@ PLyObject_ToBytea(PLyObToDatum arg, PyObject plrv,`
`901`	`901`	`bool *isnull, bool inarray)`
`902`	`902`	`{`
`903`	`903`	`PyObject *volatile plrv_so = NULL;`
`904`		`- Datum rv;`
	`904`	`+ Datum rv = (Datum) 0;`
`905`	`905`
`906`	`906`	`if (plrv == Py_None)`
`907`	`907`	`{`
Original file line number	Diff line number	Diff line change
`@@ -718,7 +718,7 @@ pltclu_call_handler(PG_FUNCTION_ARGS)`
`718`	`718`	`static Datum`
`719`	`719`	`pltcl_handler(PG_FUNCTION_ARGS, bool pltrusted)`
`720`	`720`	`{`
`721`		`- Datum retval;`
	`721`	`+ Datum retval = (Datum) 0;`
`722`	`722`	`pltcl_call_state current_call_state;`
`723`	`723`	`pltcl_call_state *save_call_state;`
`724`	`724`