Change xl_hash_vacuum_one_page.ntuples from int to uint16.

Amit Kapila · Amit Kapila · commit a6cd1fc692ef · 2023-02-27T08:32:45.000+05:30
This will create two bytes of padding space in xl_hash_vacuum_one_page which can be used for future patches. This makes the datatype of xl_hash_vacuum_one_page.ntuples same as gistxlogDelete.ntodelete which is advisable as both are used for the same purpose. Author: Bertrand Drouvot Reviewed-by: Nathan Bossart Discussion: https://postgr.es/m/b0e20c40-cb7a-fc1c-c607-2a78dac5021e@gmail.com
diff --git a/src/include/access/hash_xlog.h b/src/include/access/hash_xlog.h
@@ -251,13 +251,13 @@ typedef struct xl_hash_init_bitmap_page
 typedef struct xl_hash_vacuum_one_page
 {
 	TransactionId snapshotConflictHorizon;
-	int			ntuples;
+	uint16			ntuples;
 
 	/* TARGET OFFSET NUMBERS FOLLOW AT THE END */
 } xl_hash_vacuum_one_page;
 
 #define SizeOfHashVacuumOnePage \
-	(offsetof(xl_hash_vacuum_one_page, ntuples) + sizeof(int))
+	(offsetof(xl_hash_vacuum_one_page, ntuples) + sizeof(uint16))
 
 extern void hash_redo(XLogReaderState *record);
 extern void hash_desc(StringInfo buf, XLogReaderState *record);
diff --git a/src/include/access/xlog_internal.h b/src/include/access/xlog_internal.h
@@ -31,7 +31,7 @@
 /*
  * Each page of XLOG file has a header like this:
  */
-#define XLOG_PAGE_MAGIC 0xD111	/* can be used as WAL version indicator */
+#define XLOG_PAGE_MAGIC 0xD112	/* can be used as WAL version indicator */
 
 typedef struct XLogPageHeaderData
 {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`/*`
`32`	`32`	`* Each page of XLOG file has a header like this:`
`33`	`33`	`*/`
`34`		`-#define XLOG_PAGE_MAGIC 0xD111 /* can be used as WAL version indicator */`
	`34`	`+#define XLOG_PAGE_MAGIC 0xD112 /* can be used as WAL version indicator */`
`35`	`35`
`36`	`36`	`typedef struct XLogPageHeaderData`
`37`	`37`	`{`