Fix memory leak in tar file padding

mhagander · mhagander · commit a775406ec439 · 2016-10-30T14:10:39.000+01:00
Spotted by Coverity, patch by Michael Paquier
diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c
@@ -442,9 +442,14 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes)
 		ssize_t		r = tar_write(f, zerobuf, bytestowrite);
 
 		if (r < 0)
+		{
+			pg_free(zerobuf);
 			return false;
+		}
 		bytesleft -= r;
 	}
+
+	pg_free(zerobuf);
 	return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -442,9 +442,14 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes)`
`442`	`442`	`ssize_t r = tar_write(f, zerobuf, bytestowrite);`
`443`	`443`
`444`	`444`	`if (r < 0)`
	`445`	`+ {`
	`446`	`+ pg_free(zerobuf);`
`445`	`447`	`return false;`
	`448`	`+ }`
`446`	`449`	`bytesleft -= r;`
`447`	`450`	`}`
	`451`	`+`
	`452`	`+ pg_free(zerobuf);`
`448`	`453`	`return true;`
`449`	`454`	`}`
`450`	`455`