Skip to content

Commit a82ba06

Browse files
committed
Remove erroneous assertion from pg_copy_logical_replication_slot().
If restart_lsn of logical replication slot gets behind more than max_slot_wal_keep_size from the current LSN, the logical replication slot would be invalidated and its restart_lsn is reset to an invalid LSN. If this logical replication slot with an invalid restart_lsn was specified as the source slot in pg_copy_logical_replication_slot(), the function caused the assertion failure unexpectedly. This assertion was added because restart_lsn should not be invalid before. But in v13, it can be invalid thanks to max_slot_wal_keep_size. So since this assertion is no longer useful, this commit removes it. This commit also changes the errcode in the error message that pg_copy_logical_replication_slot() emits when the slot with an invalid restart_lsn is specified, to more appropriate one. Back-patch to v13 where max_slot_wal_keep_size was added and the assertion was no longer valid. Author: Fujii Masao Reviewed-by: Alvaro Herrera, Kyotaro Horiguchi Discussion: https://postgr.es/m/f91de4fb-a7ab-b90e-8132-74796e049d51@oss.nttdata.com
1 parent 235c0f6 commit a82ba06

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

src/backend/replication/slotfuncs.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -755,12 +755,9 @@ copy_replication_slot(FunctionCallInfo fcinfo, bool logical_slot)
755755

756756
/* Copying non-reserved slot doesn't make sense */
757757
if (XLogRecPtrIsInvalid(src_restart_lsn))
758-
{
759-
Assert(!logical_slot);
760758
ereport(ERROR,
761-
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
759+
(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
762760
errmsg("cannot copy a replication slot that doesn't reserve WAL")));
763-
}
764761

765762
/* Overwrite params from optional arguments */
766763
if (PG_NARGS() >= 3)

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy