Fix uninitialized-variable compiler warning induced by commit e4128ee.

tglsfdc · tglsfdc · commit a852cfe96752 · 2017-12-03T11:25:17.000-05:00
I'm a little bit astonished that anyone's compiler would have failed to
complain about this.  The compiler surely does not know that is_procedure
means the function return value will be ignored.
diff --git a/src/pl/plpython/plpy_exec.c b/src/pl/plpython/plpy_exec.c
@@ -210,6 +210,8 @@ PLy_exec_function(FunctionCallInfo fcinfo, PLyProcedure *proc)
 				ereport(ERROR,
 						(errcode(ERRCODE_DATATYPE_MISMATCH),
 						 errmsg("PL/Python procedure did not return None")));
+			fcinfo->isnull = false;
+			rv = (Datum) 0;
 		}
 		else if (proc->result.typoid == VOIDOID)
 		{

Original file line number	Diff line number	Diff line change
`@@ -210,6 +210,8 @@ PLy_exec_function(FunctionCallInfo fcinfo, PLyProcedure *proc)`
`210`	`210`	`ereport(ERROR,`
`211`	`211`	`(errcode(ERRCODE_DATATYPE_MISMATCH),`
`212`	`212`	`errmsg("PL/Python procedure did not return None")));`
	`213`	`+ fcinfo->isnull = false;`
	`214`	`+ rv = (Datum) 0;`
`213`	`215`	`}`
`214`	`216`	`else if (proc->result.typoid == VOIDOID)`
`215`	`217`	`{`