Convert MemoryContextSwitchTo() into an inline function when using GCC.

tglsfdc · tglsfdc · commit a8593a34632a · 2005-02-18T21:52:34.000Z
diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c
@@ -14,7 +14,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.53 2004/12/31 22:02:48 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.54 2005/02/18 21:52:33 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -619,7 +619,13 @@ repalloc(void *pointer, Size size)
 /*
  * MemoryContextSwitchTo
  *		Returns the current context; installs the given context.
+ *
+ * This is inlined when using GCC.
+ *
+ * TODO: investigate supporting inlining for some non-GCC compilers.
  */
+#ifndef __GNUC__
+
 MemoryContext
 MemoryContextSwitchTo(MemoryContext context)
 {
@@ -632,6 +638,8 @@ MemoryContextSwitchTo(MemoryContext context)
 	return old;
 }
 
+#endif   /* ! __GNUC__ */
+
 /*
  * MemoryContextStrdup
  *		Like strdup(), but allocate from the specified context
diff --git a/src/include/utils/palloc.h b/src/include/utils/palloc.h
@@ -21,7 +21,7 @@
  * Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/include/utils/palloc.h,v 1.32 2004/12/31 22:03:46 pgsql Exp $
+ * $PostgreSQL: pgsql/src/include/utils/palloc.h,v 1.33 2005/02/18 21:52:34 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -70,8 +70,26 @@ extern void pfree(void *pointer);
 
 extern void *repalloc(void *pointer, Size size);
 
+/*
+ * MemoryContextSwitchTo can't be a macro in standard C compilers.
+ * But we can make it an inline function when using GCC.
+ */
+#ifdef __GNUC__
+
+static __inline__ MemoryContext
+MemoryContextSwitchTo(MemoryContext context)
+{
+	MemoryContext old = CurrentMemoryContext;
+	CurrentMemoryContext = context;
+	return old;
+}
+
+#else
+
 extern MemoryContext MemoryContextSwitchTo(MemoryContext context);
 
+#endif   /* __GNUC__ */
+
 /*
  * These are like standard strdup() except the copied string is
  * allocated in a context, not with malloc().

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`*`
`15`	`15`	`*`
`16`	`16`	`* IDENTIFICATION`
`17`		`- * $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.53 2004/12/31 22:02:48 pgsql Exp $`
	`17`	`+ * $PostgreSQL: pgsql/src/backend/utils/mmgr/mcxt.c,v 1.54 2005/02/18 21:52:33 tgl Exp $`
`18`	`18`	`*`
`19`	`19`	`*-------------------------------------------------------------------------`
`20`	`20`	`*/`
`@@ -619,7 +619,13 @@ repalloc(void *pointer, Size size)`
`619`	`619`	`/*`
`620`	`620`	`* MemoryContextSwitchTo`
`621`	`621`	`* Returns the current context; installs the given context.`
	`622`	`+ *`
	`623`	`+ * This is inlined when using GCC.`
	`624`	`+ *`
	`625`	`+ * TODO: investigate supporting inlining for some non-GCC compilers.`
`622`	`626`	`*/`
	`627`	`+#ifndef __GNUC__`
	`628`	`+`
`623`	`629`	`MemoryContext`
`624`	`630`	`MemoryContextSwitchTo(MemoryContext context)`
`625`	`631`	`{`
`@@ -632,6 +638,8 @@ MemoryContextSwitchTo(MemoryContext context)`
`632`	`638`	`return old;`
`633`	`639`	`}`
`634`	`640`
	`641`	`+#endif /* ! __GNUC__ */`
	`642`	`+`
`635`	`643`	`/*`
`636`	`644`	`* MemoryContextStrdup`
`637`	`645`	`* Like strdup(), but allocate from the specified context`