Fix off-by-one in newly-introdcued GIN assertion.

hlinnaka · hlinnaka · commit a8f374849fe2 · 2014-01-24T11:10:09.000+02:00
Spotted by Alexander Korotkov
diff --git a/src/backend/access/gin/gindatapage.c b/src/backend/access/gin/gindatapage.c
@@ -815,7 +815,7 @@ dataPlaceToPageLeafRecompress(Buffer buf, disassembledLeaf *leaf,
 		ptr += segsize;
 		newsize += segsize;
 	}
-	Assert(newsize < GinDataLeafMaxContentSize);
+	Assert(newsize <= GinDataLeafMaxContentSize);
 	GinDataLeafPageSetPostingListSize(page, newsize);
 	GinPageSetCompressed(page);	 /* in case it was in pre-9.4 format before */
 

Original file line number	Diff line number	Diff line change
`@@ -815,7 +815,7 @@ dataPlaceToPageLeafRecompress(Buffer buf, disassembledLeaf *leaf,`
`815`	`815`	`ptr += segsize;`
`816`	`816`	`newsize += segsize;`
`817`	`817`	`}`
`818`		`- Assert(newsize < GinDataLeafMaxContentSize);`
	`818`	`+ Assert(newsize <= GinDataLeafMaxContentSize);`
`819`	`819`	`GinDataLeafPageSetPostingListSize(page, newsize);`
`820`	`820`	`GinPageSetCompressed(page); /* in case it was in pre-9.4 format before */`
`821`	`821`