Remove redundant _bt_killitems() buffer check.

petergeoghegan · petergeoghegan · commit ab2343d4cb80 · 2020-04-29T18:17:49.000-07:00
_bt_getbuf() cannot return an invalid buffer. Oversight in commit 2ed5b87.
diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c
@@ -1756,10 +1756,6 @@ _bt_killitems(IndexScanDesc scan)
 		/* Attempt to re-read the buffer, getting pin and lock. */
 		buf = _bt_getbuf(scan->indexRelation, so->currPos.currPage, BT_READ);
 
-		/* It might not exist anymore; in which case we can't hint it. */
-		if (!BufferIsValid(buf))
-			return;
-
 		page = BufferGetPage(buf);
 		if (BufferGetLSNAtomic(buf) == so->currPos.lsn)
 			so->currPos.buf = buf;
