Fix typo in relcache's equalPolicy()

sfrost · sfrost · commit ab6d1cd26ebf · 2015-04-17T16:37:11.000-04:00
The USING policies were not being checked for differences as the same
policy was being passed in to both sides of the equal().  This could
result in backends not realizing that a policy had been changed, if
none of the other attributes had been changed.

Fix by passing to equal() the policy1 and policy2 using quals for
comparison.

No need to back-patch as this is not yet released.  Noticed while
testing changes to RLS proposed by Dean Rasheed.
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
@@ -887,7 +887,7 @@ equalPolicy(RowSecurityPolicy *policy1, RowSecurityPolicy *policy2)
 				return false;
 		}
 
-		if (!equal(policy1->qual, policy1->qual))
+		if (!equal(policy1->qual, policy2->qual))
 			return false;
 		if (!equal(policy1->with_check_qual, policy2->with_check_qual))
 			return false;

Original file line number	Diff line number	Diff line change
`@@ -887,7 +887,7 @@ equalPolicy(RowSecurityPolicy policy1, RowSecurityPolicy policy2)`
`887`	`887`	`return false;`
`888`	`888`	`}`
`889`	`889`
`890`		`- if (!equal(policy1->qual, policy1->qual))`
	`890`	`+ if (!equal(policy1->qual, policy2->qual))`
`891`	`891`	`return false;`
`892`	`892`	`if (!equal(policy1->with_check_qual, policy2->with_check_qual))`
`893`	`893`	`return false;`