Fix perlcritic warnings

petere · petere · commit abcba7001e48 · 2018-02-22T15:13:57.000-05:00
diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -584,22 +584,22 @@ sub check_pgbench_logs
 {
 	my ($prefix, $nb, $min, $max, $re) = @_;
 
-	my @logs = <$prefix.*>;
+	my @logs = glob "$prefix.*";
 	ok(@logs == $nb, "number of log files");
 	ok(grep(/^$prefix\.\d+(\.\d+)?$/, @logs) == $nb, "file name format");
 
 	my $log_number = 0;
 	for my $log (sort @logs)
 	{
 		eval {
-			open LOG, $log or die "$@";
-			my @contents = <LOG>;
+			open my $fh, '<', $log or die "$@";
+			my @contents = <$fh>;
 			my $clen     = @contents;
 			ok( $min <= $clen && $clen <= $max,
 				"transaction count for $log ($clen)");
 			ok( grep($re, @contents) == $clen,
 				"transaction format for $prefix");
-			close LOG or die "$@";
+			close $fh or die "$@";
 		};
 	}
 	ok(unlink(@logs), "remove log files");
