Correct nbtsplitloc.c comment.

petergeoghegan · petergeoghegan · commit ac37bd51a422 · 2019-07-15T14:35:05.000-07:00
The logic just added by commit e3899ff falls back on a 50:50 page split in the event of a new item that's just to the right of our provisional "many duplicates" split point. Fix a comment that incorrectly claimed that the new item had to be just to the left of our provisional split point. Backpatch: 12-, just like commit e3899ff.
diff --git a/src/backend/access/nbtree/nbtsplitloc.c b/src/backend/access/nbtree/nbtsplitloc.c
@@ -815,7 +815,7 @@ _bt_bestsplitloc(FindSplitData *state, int perfectpenalty,
 	{
 		/*
 		 * Avoid the problem by peforming a 50:50 split when the new item is
-		 * just to the left of the would-be "many duplicates" split point.
+		 * just to the right of the would-be "many duplicates" split point.
 		 */
 		final = &state->splits[0];
 	}

Original file line number	Diff line number	Diff line change
`@@ -815,7 +815,7 @@ _bt_bestsplitloc(FindSplitData *state, int perfectpenalty,`
`815`	`815`	`{`
`816`	`816`	`/*`
`817`	`817`	`* Avoid the problem by peforming a 50:50 split when the new item is`
`818`		`- * just to the left of the would-be "many duplicates" split point.`
	`818`	`+ * just to the right of the would-be "many duplicates" split point.`
`819`	`819`	`*/`
`820`	`820`	`final = &state->splits[0];`
`821`	`821`	`}`