Improve msys2 detection for TAP tests

adunstan · adunstan · commit acea505186e6 · 2022-01-27T08:27:56.000-05:00
Perl instances on some msys toolchains (e.g. UCRT64) have their
configured osname set to 'MSWin32' rather than 'msys'.  The test for
the msys2 platform is adjusted accordingly.

Backpatch to release 14.
diff --git a/src/test/perl/PostgreSQL/Test/Utils.pm b/src/test/perl/PostgreSQL/Test/Utils.pm
@@ -142,7 +142,8 @@ BEGIN
 	# Must be set early
 	$windows_os = $Config{osname} eq 'MSWin32' || $Config{osname} eq 'msys';
 	# Check if this environment is MSYS2.
-	$is_msys2 = $^O eq 'msys' && `uname -or` =~ /^[2-9].*Msys/;
+	$is_msys2 = $windows_os && -x '/usr/bin/uname'  &&
+	  `uname -or` =~ /^[2-9].*Msys/;
 
 	if ($windows_os)
 	{

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,8 @@ BEGIN`
`142`	`142`	`# Must be set early`
`143`	`143`	`$windows_os = $Config{osname} eq 'MSWin32' \|\| $Config{osname} eq 'msys';`
`144`	`144`	`# Check if this environment is MSYS2.`
`145`		- $is_msys2 = $^O eq 'msys' && `uname -or` =~ /^[2-9].*Msys/;
	`145`	`+ $is_msys2 = $windows_os && -x '/usr/bin/uname' &&`
	`146`	+ `uname -or` =~ /^[2-9].*Msys/;
`146`	`147`
`147`	`148`	`if ($windows_os)`
`148`	`149`	`{`