Make PostgreSQL::Test::Cluster::run_log() return a useful value.

robertmhaas · robertmhaas · commit ad4f2c47de44 · 2022-03-29T16:58:24.000-04:00
Curently, some TAP test that directly call the underlying function PostgreSQL::Test::Utils::run_log() care about the return value, but none of those that call it via PostgreSQL::Test::Cluster::run_log() care. However, I'd like to add a test that will care, so adjust this function to return whatever it gets back from the underlying function, just as we do for a number of other functions in this module. Discussion: http://postgr.es/m/CA+Tgmobj6u-nWF-j=FemygUhobhryLxf9h-wJN7W-2rSsseHNA@mail.gmail.com
diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
@@ -2502,8 +2502,7 @@ sub run_log
 
 	local %ENV = $self->_get_env();
 
-	PostgreSQL::Test::Utils::run_log(@_);
-	return;
+	return PostgreSQL::Test::Utils::run_log(@_);
 }
 
 =pod

Original file line number	Diff line number	Diff line change
`@@ -2502,8 +2502,7 @@ sub run_log`
`2502`	`2502`
`2503`	`2503`	`local %ENV = $self->_get_env();`
`2504`	`2504`
`2505`		`- PostgreSQL::Test::Utils::run_log(@_);`
`2506`		`- return;`
	`2505`	`+ return PostgreSQL::Test::Utils::run_log(@_);`
`2507`	`2506`	`}`
`2508`	`2507`
`2509`	`2508`	`=pod`