Skip to content

Commit ad51c6f

Browse files
committed
Remove pgbench "progress" test pending solution of its timing issues.
Buildfarm member skink shows that this is even more flaky than I thought. There are probably some actual pgbench bugs here as well as a timing dependency. But we can't have stuff this unstable in the buildfarm, it obscures other issues.
1 parent 01c7d3e commit ad51c6f

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

src/bin/pgbench/t/001_pgbench_with_server.pl

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -445,28 +445,6 @@ sub check_pgbench_logs
445445
ok(unlink(@logs), "remove log files");
446446
}
447447

448-
# note: --progress-timestamp is not tested
449-
pgbench(
450-
'-T 2 -P 1 -l --log-prefix=001_pgbench_log_1 --aggregate-interval=1'
451-
. ' -S -b se@2 --rate=20 --latency-limit=1000 -j ' . $nthreads
452-
. ' -c 3 -r',
453-
0,
454-
[ qr{type: multiple},
455-
qr{clients: 3},
456-
qr{threads: $nthreads},
457-
qr{duration: 2 s},
458-
qr{script 1: .* select only},
459-
qr{script 2: .* select only},
460-
qr{statement latencies in milliseconds},
461-
qr{FROM pgbench_accounts} ],
462-
[ qr{vacuum}, qr{progress: 1\b} ],
463-
'pgbench progress');
464-
465-
# $nthreads threads, 2 seconds, but due to timing imprecision we might get
466-
# only 1 or as many as 3 progress reports per thread.
467-
check_pgbench_logs('001_pgbench_log_1', $nthreads, 1, 3,
468-
qr{^\d+ \d{1,2} \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+ \d+$});
469-
470448
# with sampling rate
471449
pgbench(
472450
'-n -S -t 50 -c 2 --log --log-prefix=001_pgbench_log_2 --sampling-rate=0.5',

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy