Fix pg_size_pretty() to avoid overflow for inputs close to INT64_MAX.

tglsfdc · tglsfdc · commit af0f20092c86 · 2011-04-25T16:22:12.000-04:00
The expression that tried to round the value to the nearest TB could
overflow, leading to bogus output as reported in bug #5993 from Nicola
Cossu.  This isn't likely to ever happen in the intended usage of the
function (if it could, we'd be needing to use a wider datatype instead);
but it's not hard to give the expected output, so let's do so.
diff --git a/src/backend/utils/adt/dbsize.c b/src/backend/utils/adt/dbsize.c
@@ -490,9 +490,15 @@ pg_size_pretty(PG_FUNCTION_ARGS)
 							 (size + mult / 2) / mult);
 				else
 				{
+					/* Here we have to worry about avoiding overflow */
+					int64	val;
+
 					mult *= 1024;
+					val = size / mult;
+					if ((size % mult) >= (mult / 2))
+						val++;
 					snprintf(buf, sizeof(buf), INT64_FORMAT " TB",
-							 (size + mult / 2) / mult);
+							 val);
 				}
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -490,9 +490,15 @@ pg_size_pretty(PG_FUNCTION_ARGS)`
`490`	`490`	`(size + mult / 2) / mult);`
`491`	`491`	`else`
`492`	`492`	`{`
	`493`	`+ /* Here we have to worry about avoiding overflow */`
	`494`	`+ int64 val;`
	`495`	`+`
`493`	`496`	`mult *= 1024;`
	`497`	`+ val = size / mult;`
	`498`	`+ if ((size % mult) >= (mult / 2))`
	`499`	`+ val++;`
`494`	`500`	`snprintf(buf, sizeof(buf), INT64_FORMAT " TB",`
`495`		`- (size + mult / 2) / mult);`
	`501`	`+ val);`
`496`	`502`	`}`
`497`	`503`	`}`
`498`	`504`	`}`