Add some const decorations (htup.h)

petere · petere · commit b15b8c5cf882 · 2025-01-23T12:12:08.000+01:00
Discussion: https://www.postgresql.org/message-id/flat/5b558da8-99fb-0a99-83dd-f72f05388517@enterprisedb.com
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -7437,10 +7437,10 @@ MultiXactIdGetUpdateXid(TransactionId xmax, uint16 t_infomask)
  * checking the hint bits.
  */
 TransactionId
-HeapTupleGetUpdateXid(HeapTupleHeader tuple)
+HeapTupleGetUpdateXid(const HeapTupleHeaderData *tup)
 {
-	return MultiXactIdGetUpdateXid(HeapTupleHeaderGetRawXmax(tuple),
-								   tuple->t_infomask);
+	return MultiXactIdGetUpdateXid(HeapTupleHeaderGetRawXmax(tup),
+								   tup->t_infomask);
 }
 
 /*
diff --git a/src/backend/utils/time/combocid.c b/src/backend/utils/time/combocid.c
@@ -101,7 +101,7 @@ static CommandId GetRealCmax(CommandId combocid);
  */
 
 CommandId
-HeapTupleHeaderGetCmin(HeapTupleHeader tup)
+HeapTupleHeaderGetCmin(const HeapTupleHeaderData *tup)
 {
 	CommandId	cid = HeapTupleHeaderGetRawCommandId(tup);
 
@@ -115,7 +115,7 @@ HeapTupleHeaderGetCmin(HeapTupleHeader tup)
 }
 
 CommandId
-HeapTupleHeaderGetCmax(HeapTupleHeader tup)
+HeapTupleHeaderGetCmax(const HeapTupleHeaderData *tup)
 {
 	CommandId	cid = HeapTupleHeaderGetRawCommandId(tup);
 
@@ -150,7 +150,7 @@ HeapTupleHeaderGetCmax(HeapTupleHeader tup)
  * changes the tuple in shared buffers.
  */
 void
-HeapTupleHeaderAdjustCmax(HeapTupleHeader tup,
+HeapTupleHeaderAdjustCmax(const HeapTupleHeaderData *tup,
 						  CommandId *cmax,
 						  bool *iscombo)
 {
diff --git a/src/include/access/htup.h b/src/include/access/htup.h
@@ -78,12 +78,12 @@ typedef HeapTupleData *HeapTuple;
 #define HeapTupleIsValid(tuple) PointerIsValid(tuple)
 
 /* HeapTupleHeader functions implemented in utils/time/combocid.c */
-extern CommandId HeapTupleHeaderGetCmin(HeapTupleHeader tup);
-extern CommandId HeapTupleHeaderGetCmax(HeapTupleHeader tup);
-extern void HeapTupleHeaderAdjustCmax(HeapTupleHeader tup,
+extern CommandId HeapTupleHeaderGetCmin(const HeapTupleHeaderData *tup);
+extern CommandId HeapTupleHeaderGetCmax(const HeapTupleHeaderData *tup);
+extern void HeapTupleHeaderAdjustCmax(const HeapTupleHeaderData *tup,
 									  CommandId *cmax, bool *iscombo);
 
 /* Prototype for HeapTupleHeader accessors in heapam.c */
-extern TransactionId HeapTupleGetUpdateXid(HeapTupleHeader tuple);
+extern TransactionId HeapTupleGetUpdateXid(const HeapTupleHeaderData *tup);
 
 #endif							/* HTUP_H */

Original file line number	Diff line number	Diff line change
`@@ -7437,10 +7437,10 @@ MultiXactIdGetUpdateXid(TransactionId xmax, uint16 t_infomask)`
`7437`	`7437`	`* checking the hint bits.`
`7438`	`7438`	`*/`
`7439`	`7439`	`TransactionId`
`7440`		`-HeapTupleGetUpdateXid(HeapTupleHeader tuple)`
	`7440`	`+HeapTupleGetUpdateXid(const HeapTupleHeaderData *tup)`
`7441`	`7441`	`{`
`7442`		`- return MultiXactIdGetUpdateXid(HeapTupleHeaderGetRawXmax(tuple),`
`7443`		`- tuple->t_infomask);`
	`7442`	`+ return MultiXactIdGetUpdateXid(HeapTupleHeaderGetRawXmax(tup),`
	`7443`	`+ tup->t_infomask);`
`7444`	`7444`	`}`
`7445`	`7445`
`7446`	`7446`	`/*`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ static CommandId GetRealCmax(CommandId combocid);`
`101`	`101`	`*/`
`102`	`102`
`103`	`103`	`CommandId`
`104`		`-HeapTupleHeaderGetCmin(HeapTupleHeader tup)`
	`104`	`+HeapTupleHeaderGetCmin(const HeapTupleHeaderData *tup)`
`105`	`105`	`{`
`106`	`106`	`CommandId cid = HeapTupleHeaderGetRawCommandId(tup);`
`107`	`107`
`@@ -115,7 +115,7 @@ HeapTupleHeaderGetCmin(HeapTupleHeader tup)`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`CommandId`
`118`		`-HeapTupleHeaderGetCmax(HeapTupleHeader tup)`
	`118`	`+HeapTupleHeaderGetCmax(const HeapTupleHeaderData *tup)`
`119`	`119`	`{`
`120`	`120`	`CommandId cid = HeapTupleHeaderGetRawCommandId(tup);`
`121`	`121`
`@@ -150,7 +150,7 @@ HeapTupleHeaderGetCmax(HeapTupleHeader tup)`
`150`	`150`	`* changes the tuple in shared buffers.`
`151`	`151`	`*/`
`152`	`152`	`void`
`153`		`-HeapTupleHeaderAdjustCmax(HeapTupleHeader tup,`
	`153`	`+HeapTupleHeaderAdjustCmax(const HeapTupleHeaderData *tup,`
`154`	`154`	`CommandId *cmax,`
`155`	`155`	`bool *iscombo)`
`156`	`156`	`{`