Fix HEAP_INSERT_IS_SPECULATIVE to HEAP_INSERT_SPECULATIVE in comments.

anarazel · anarazel · commit b2a177bff10e · 2018-03-05T15:28:03.000-08:00
This was wrong since 168d580, which introduced speculative inserts. Author: Andres Freund
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -2411,7 +2411,7 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)
  * This causes rows to be frozen, which is an MVCC violation and
  * requires explicit options chosen by user.
  *
- * HEAP_INSERT_IS_SPECULATIVE is used on so-called "speculative insertions",
+ * HEAP_INSERT_SPECULATIVE is used on so-called "speculative insertions",
  * which can be backed out afterwards without aborting the whole transaction.
  * Other sessions can wait for the speculative insertion to be confirmed,
  * turning it into a regular tuple, or aborted, as if it never existed.
@@ -2420,8 +2420,8 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)
  *
  * Note that most of these options will be applied when inserting into the
  * heap's TOAST table, too, if the tuple requires any out-of-line data.  Only
- * HEAP_INSERT_IS_SPECULATIVE is explicitly ignored, as the toast data does
- * not partake in speculative insertion.
+ * HEAP_INSERT_SPECULATIVE is explicitly ignored, as the toast data does not
+ * partake in speculative insertion.
  *
  * The BulkInsertState object (if any; bistate can be NULL for default
  * behavior) is also just passed through to RelationGetBufferForTuple.

Original file line number	Diff line number	Diff line change
`@@ -2411,7 +2411,7 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)`
`2411`	`2411`	`* This causes rows to be frozen, which is an MVCC violation and`
`2412`	`2412`	`* requires explicit options chosen by user.`
`2413`	`2413`	`*`
`2414`		`- * HEAP_INSERT_IS_SPECULATIVE is used on so-called "speculative insertions",`
	`2414`	`+ * HEAP_INSERT_SPECULATIVE is used on so-called "speculative insertions",`
`2415`	`2415`	`* which can be backed out afterwards without aborting the whole transaction.`
`2416`	`2416`	`* Other sessions can wait for the speculative insertion to be confirmed,`
`2417`	`2417`	`* turning it into a regular tuple, or aborted, as if it never existed.`
`@@ -2420,8 +2420,8 @@ ReleaseBulkInsertStatePin(BulkInsertState bistate)`
`2420`	`2420`	`*`
`2421`	`2421`	`* Note that most of these options will be applied when inserting into the`
`2422`	`2422`	`* heap's TOAST table, too, if the tuple requires any out-of-line data. Only`
`2423`		`- * HEAP_INSERT_IS_SPECULATIVE is explicitly ignored, as the toast data does`
`2424`		`- * not partake in speculative insertion.`
	`2423`	`+ * HEAP_INSERT_SPECULATIVE is explicitly ignored, as the toast data does not`
	`2424`	`+ * partake in speculative insertion.`
`2425`	`2425`	`*`
`2426`	`2426`	`* The BulkInsertState object (if any; bistate can be NULL for default`
`2427`	`2427`	`* behavior) is also just passed through to RelationGetBufferForTuple.`