Don't try to rewrite NEW references in a utility statement in a rule.

tglsfdc · tglsfdc · commit b2b565636209 · 2004-08-07T17:40:49.000Z
There won't be any, and in fact there won't even be an RTE for NEW,
which was leading to a core dump in CVS tip.  7.4 and earlier manage
not to crash when applying ResolveNew in this scenario, but I think
it was just good fortune that they didn't.  Per report from
Bernd Helmle.
diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.140 2004/06/16 01:26:46 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.141 2004/08/07 17:40:49 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -208,7 +208,8 @@ rewriteRuleAction(Query *parsetree,
 	 * apply it to sub_action; we have to remember to update the sublink
 	 * inside rule_action, too.
 	 */
-	if (event == CMD_INSERT || event == CMD_UPDATE)
+	if ((event == CMD_INSERT || event == CMD_UPDATE) &&
+		sub_action->commandType != CMD_UTILITY)
 	{
 		sub_action = (Query *) ResolveNew((Node *) sub_action,
 										  new_varno,

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.140 2004/06/16 01:26:46 tgl Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/rewrite/rewriteHandler.c,v 1.141 2004/08/07 17:40:49 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -208,7 +208,8 @@ rewriteRuleAction(Query *parsetree,`
`208`	`208`	`* apply it to sub_action; we have to remember to update the sublink`
`209`	`209`	`* inside rule_action, too.`
`210`	`210`	`*/`
`211`		`- if (event == CMD_INSERT \|\| event == CMD_UPDATE)`
	`211`	`+ if ((event == CMD_INSERT \|\| event == CMD_UPDATE) &&`
	`212`	`+ sub_action->commandType != CMD_UTILITY)`
`212`	`213`	`{`
`213`	`214`	`sub_action = (Query ) ResolveNew((Node ) sub_action,`
`214`	`215`	`new_varno,`