Minor cleanup for recent SQLSTATE / SQLERRM patch: spell "successful"

Neil Conway · Neil Conway · commit b3195dae49b0 · 2005-05-26T03:18:53.000Z
correctly, style fixes.
diff --git a/src/pl/plpgsql/src/gram.y b/src/pl/plpgsql/src/gram.y
@@ -4,7 +4,7 @@
  *						  procedural language
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.70 2005/05/26 00:16:31 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.71 2005/05/26 03:18:53 neilc Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -285,7 +285,8 @@ fict_vars_sect	:
 										 plpgsql_build_datatype(TEXTOID, -1), true);  
 						$$.sqlerrm_varno = var->dno;
 						plpgsql_add_initdatums(NULL);
-					};
+					}
+				;
 
 decl_sect		: opt_label
 					{
diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
@@ -3,7 +3,7 @@
  *			  procedural language
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.139 2005/05/26 00:16:31 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.140 2005/05/26 03:18:53 neilc Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -760,7 +760,7 @@ exec_stmt_block(PLpgSQL_execstate *estate, PLpgSQL_stmt_block *block)
   	var = (PLpgSQL_var *) (estate->datums[block->sqlerrm_varno]);
    	var->isnull = false;
   	var->freeval = true;
-  	var->value = DirectFunctionCall1(textin, CStringGetDatum("Sucessful completion"));
+  	var->value = DirectFunctionCall1(textin, CStringGetDatum("Successful completion"));
 
 	/*
 	 * First initialize all variables declared in this block
@@ -777,7 +777,7 @@ exec_stmt_block(PLpgSQL_execstate *estate, PLpgSQL_stmt_block *block)
 
 					if (var->freeval)
 					{
-						pfree((void *) (var->value));
+						pfree(DatumGetPointer(var->value));
 						var->freeval = false;
 					}
 
@@ -872,13 +872,12 @@ exec_stmt_block(PLpgSQL_execstate *estate, PLpgSQL_stmt_block *block)
 			CurrentResourceOwner = oldowner;
  
 			/* set SQLSTATE and SQLERRM variables */
-		    
 			var = (PLpgSQL_var *) (estate->datums[block->sqlstate_varno]);
-			pfree((void *) (var->value));
+			pfree(DatumGetPointer(var->value));
 			var->value = DirectFunctionCall1(textin, CStringGetDatum(unpack_sql_state(edata->sqlerrcode)));
-  
+
 			var = (PLpgSQL_var *) (estate->datums[block->sqlerrm_varno]);
-			pfree((void *) (var->value));
+			pfree(DatumGetPointer(var->value));
 			var->value = DirectFunctionCall1(textin, CStringGetDatum(edata->message));
 
 			/*
diff --git a/src/test/regress/expected/plpgsql.out b/src/test/regress/expected/plpgsql.out
@@ -2381,7 +2381,7 @@ CONTEXT:  PL/pgSQL function "missing_return_expr"
 drop function void_return_expr();
 drop function missing_return_expr();
 -- test SQLSTATE and SQLERRM
-create or replace function trap_exceptions() returns void as $_$
+create function trap_exceptions() returns void as $_$
 begin
    begin
      raise exception 'first exception';
@@ -2398,7 +2398,7 @@ begin
 end; $_$ language plpgsql;
 select trap_exceptions();
 NOTICE:  P0001 first exception
-NOTICE:  00000 Sucessful completion
+NOTICE:  00000 Successful completion
 NOTICE:  P0001 last exception
  trap_exceptions 
 -----------------
diff --git a/src/test/regress/sql/plpgsql.sql b/src/test/regress/sql/plpgsql.sql
@@ -2018,8 +2018,9 @@ select missing_return_expr();
 
 drop function void_return_expr();
 drop function missing_return_expr();
+
 -- test SQLSTATE and SQLERRM
-create or replace function trap_exceptions() returns void as $_$
+create function trap_exceptions() returns void as $_$
 begin
    begin
      raise exception 'first exception';

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`* procedural language`
`5`	`5`	`*`
`6`	`6`	`* IDENTIFICATION`
`7`		`- * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.70 2005/05/26 00:16:31 momjian Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/pl/plpgsql/src/gram.y,v 1.71 2005/05/26 03:18:53 neilc Exp $`
`8`	`8`	`*`
`9`	`9`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`10`	`10`	`*`
`@@ -285,7 +285,8 @@ fict_vars_sect :`
`285`	`285`	`plpgsql_build_datatype(TEXTOID, -1), true);`
`286`	`286`	`$$.sqlerrm_varno = var->dno;`
`287`	`287`	`plpgsql_add_initdatums(NULL);`
`288`		`- };`
	`288`	`+ }`
	`289`	`+ ;`
`289`	`290`
`290`	`291`	`decl_sect : opt_label`
`291`	`292`	`{`