pg_stat_statements forgot to let previous occupant of hook get control too.

tglsfdc · tglsfdc · commit b4eb2d5cc044 · 2014-04-21T13:28:13.000-04:00
pgss_post_parse_analyze() neglected to pass the call on to any earlier
occupant of the post_parse_analyze_hook.  There are no other users of that
hook in contrib/, and most likely none in the wild either, so this is
probably just a latent bug.  But it's a bug nonetheless, so back-patch
to 9.2 where this code was introduced.
diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c
@@ -614,6 +614,9 @@ pgss_post_parse_analyze(ParseState *pstate, Query *query)
 {
 	pgssJumbleState jstate;
 
+	if (prev_post_parse_analyze_hook)
+		prev_post_parse_analyze_hook(pstate, query);
+
 	/* Assert we didn't do this already */
 	Assert(query->queryId == 0);
 

Original file line number	Diff line number	Diff line change
`@@ -614,6 +614,9 @@ pgss_post_parse_analyze(ParseState pstate, Query query)`
`614`	`614`	`{`
`615`	`615`	`pgssJumbleState jstate;`
`616`	`616`
	`617`	`+ if (prev_post_parse_analyze_hook)`
	`618`	`+ prev_post_parse_analyze_hook(pstate, query);`
	`619`	`+`
`617`	`620`	`/* Assert we didn't do this already */`
`618`	`621`	`Assert(query->queryId == 0);`
`619`	`622`