In pg_upgrade, report errno string if file existence check returns an

bmomjian · bmomjian · commit b55743a5df13 · 2012-11-19T16:41:58.000-05:00
error and errno != ENOENT.
diff --git a/contrib/pg_upgrade/relfilenode.c b/contrib/pg_upgrade/relfilenode.c
@@ -205,8 +205,9 @@ transfer_relfile(pageCnvCtx *pageConverter, FileNameMap *map,
 				if (errno == ENOENT)
 					return;
 				else
-					pg_log(PG_FATAL, "non-existant file error while copying relation \"%s.%s\" (\"%s\" to \"%s\")\n",
-						   map->nspname, map->relname, old_file, new_file);
+					pg_log(PG_FATAL, "error while checking for file existance \"%s.%s\" (\"%s\" to \"%s\"): %s\n",
+						   map->nspname, map->relname, old_file, new_file,
+						   getErrorText(errno));
 			}
 			close(fd);
 		}

Original file line number	Diff line number	Diff line change
`@@ -205,8 +205,9 @@ transfer_relfile(pageCnvCtx pageConverter, FileNameMap map,`
`205`	`205`	`if (errno == ENOENT)`
`206`	`206`	`return;`
`207`	`207`	`else`
`208`		`- pg_log(PG_FATAL, "non-existant file error while copying relation \"%s.%s\" (\"%s\" to \"%s\")\n",`
`209`		`- map->nspname, map->relname, old_file, new_file);`
	`208`	`+ pg_log(PG_FATAL, "error while checking for file existance \"%s.%s\" (\"%s\" to \"%s\"): %s\n",`
	`209`	`+ map->nspname, map->relname, old_file, new_file,`
	`210`	`+ getErrorText(errno));`
`210`	`211`	`}`
`211`	`212`	`close(fd);`
`212`	`213`	`}`